Support » Plugin: Embed Privacy » Enhancement: cite in blockquote instead of div for meta

Enhancement: cite in blockquote instead of div for meta

  • xwolf

    (@xwolf)


    12 months ago

    For embedding twitter feeds the citating mark (meta info for author) is sett into a div.
    E.g.:

    <blockquote class="twitter-tweet" data-width="550" data-dnt="true">
<p dir="ltr" lang="de">In der Krise sollte man nicht nach den Schuldigen suchen.<br>Sondern nach diejenigen, die den Karren aus dem Dreck ziehen.</p>
<div class="embed-privacy-tweet-meta"><span class="embed-privacy-author-meta">— Wolfgang Wiese (@xwolf) </span><a href="https://twitter.com/xwolf/status/1346219113006444546?ref_src=twsrc%5Etfw">4. Januar 2021</a></div>
</blockquote>

    I would suggest do chance the <div class="embed-privacy-tweet-meta">.. <div>
    into <cite class=”embed-privacy-tweet-meta”>…</cite> cause this is better for semantic.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor Simon Kraft

    (@krafit)

    12 months ago

    Hi Wolfgang,
    Good catch! I’ve added this as a GitHub issue to address it in the next update.
    Thank you,
    Simon

    • This reply was modified 12 months ago by Simon Kraft.
    Thread Starter xwolf

    (@xwolf)

    12 months ago

    Thxs, already got the notice 🙂

    By the way: If I have another feature requests, would it be better to post it here or as issue in github?

    (Githubs Isse Editor is somewhat better as this simple form)

    Plugin Contributor Simon Kraft

    (@krafit)

    12 months ago

    GitHub is the perfect place for feature requests. 🙃

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Enhancement: cite in blockquote instead of div for meta’ is closed to new replies.

Topic Tags

Views