Pinned
4,010 contributions in the last year
Less
More
Contribution activity
July 2021
Created 126 commits in 4 repositories
Created 1 repository
Created a pull request in PHPMailer/PHPMailer that received 5 comments
Tests: move host validation tests to own file
This is a next PR in a series of PRs to improve the test suite and make it easier to maintain. The principle of these changes was proposed to and d…
+109
−35
•
5
comments
Opened 49 other pull requests in 5 repositories
PHPMailer/PHPMailer
41
merged
- PHPMailer::setLanguage(): various fixes + add tests for localization
-
Tests: introduce dedicated tests for the
PHPMailer::html2text()
method - Tests: move (get|set|clear)ReplyTo tests to own file
- PHPMailer::parseAddresses(): bug fix [2] - Mbstring encoding
- Tests: move property setting tests to own file
- Tests: move setFrom tests to own file
- Tests: move error recording test to own file
- PHPMailer::parseAddresses(): bug fix [1] - extension availability not checked (consistently)
- Tests: move encodeQ tests to own file
- PHPmailer::getTranslations(): translations should always be available
- Tests: move encodeString tests to own file
- Tests: move addStringEmbeddedImage tests to own file
-
Tests: introduce dedicated tests for the
PHPMailer::fileIsAccessible()
method -
Tests: introduce dedicated tests for the
PHPMailer::isPermittedPath()
method - Localization: allow for more text strings to be translated
- Tests: move addStringAttachment tests to own file
- Tests: move addEmbeddedImage tests to own file
- Tests: move custom header tests to own file
- HasLineLongerThanMaxTest: switch to preSend()
- Tests: move setWordWrap tests to own file
- Tests: move puny encoding test to own file
- .gitattributes: export-ignore code coverage config file
- Utf8CharBoundaryTest: switch base test case
- SendTestCase: error out when the testbootstrap file cannot be found
-
Tests: introduce dedicated test for the
PHPMailer::generateID()
method - Some pull requests not shown.
WordPress/wordpress-develop
3
open
Yoast/whip
3
merged
PHPCompatibility/PHPCompatibilityWP
1
merged
php/doc-en
1
merged
Reviewed 7 pull requests in 4 repositories
WordPress/wordpress-develop 3 pull requests
PHPMailer/PHPMailer 2 pull requests
Yoast/whip 1 pull request
squizlabs/PHP_CodeSniffer 1 pull request
Created an issue in PHPMailer/PHPMailer that received 9 comments
Suggestions for potential improvements for PHPMailer::setLanguage()
While writing tests for the logic involved in localizing the error messages, I came across a number of oddities which may benefit from some tweaks …
9
comments
Opened 3 other issues in 2 repositories
PHPMailer/PHPMailer
1
closed
1
open
gitextensions/gitextensions
1
open
8
contributions
in private repositories
Jul 13 – Jul 15