The Wayback Machine - https://webcf.waybackmachine.org/web/20220312103509/https://github.com/mrdoob/three.js/pull/20677
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTX2Loader: Allow parse() method to initialize transcoder. #20677

Merged
merged 1 commit into from on Nov 12, 2020
Merged

KTX2Loader: Allow parse() method to initialize transcoder. #20677

merged 1 commit into from on Nov 12, 2020

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented on Nov 12, 2020

Currently .load() initializes the WASM transcoder automatically, but .parse() does not. Since the user may need to call either, depending on the situation, both should handle initialization.

@mrdoob mrdoob added this to the r123 milestone on Nov 12, 2020
@mrdoob mrdoob merged commit ebd43ff into mrdoob:dev on Nov 12, 2020
8 checks passed
@mrdoob
Copy link
Owner

@mrdoob mrdoob commented on Nov 12, 2020

Thanks!

@donmccurdy donmccurdy deleted the feat-ktx2loader-parse branch 4 years ago
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r123
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@donmccurdy @mrdoob