Change old repository link with the new one in the Readme.md #1748
Conversation
README.md
Outdated
|
|
||
| [](https://packagist.org/packages/wp-coding-standards/wpcs) | ||
| [](https://travis-ci.org/WordPress-Coding-Standards/WordPress-Coding-Standards) | ||
| [](https://travis-ci.org/WordPress/WordPress-Coding-Standards) |
There was a problem hiding this comment.
Should include 7.3 (and 7.4 snapshot?) as well.
There was a problem hiding this comment.
Oops... that should have been adjusted when I adjusted the Travis script. Mea culpa.
But as we're on the topic now anyway, we should (for now) remove nightly as we're currently not testing against nightly. See #1643
There was a problem hiding this comment.
Should I just replace the alt with Tested on PHP 5.4 to 7.4 snapshot?
There was a problem hiding this comment.
I don't favour replacing it with the short version, being explicit that we really test on all versions inbetween was the point of the badge.
I've just updated Packagist to point to the new GH repo address, so on that side things should be fine again now. I don't think we need to adjust the Packagist package name as it already didn't reflect the previous repo name 1-on-1 anyway (and would break the stats). |
|
There are a lot more places in the repo which reference the old repo address. Think: the Question: should those all be changed in one go ? Or do we update the repo bit by bit ? |
|
Regarding Packagist: We're getting mixed messages from Packagist.
I'd leave it for now, but we'll need to monitor the next time someone pushes a new branch to the repo to see if the branch shows up on Packagist correctly. If not, we may need to ask someone to grant Packagist access to the GH |
|
I'm fine with looking for old links in the entire repo and submitting it in this PR, just not to have too many PRs open that essentially are doing the same thing. |
@dingo-d That would be awesome! I'm definitely +1 on doing it in one PR (which is, of course, why I asked the question). |
Old repository links in the readme have been changed with the new ones.
Fixes #1747 issue
I'm not sure if the packagist package should be moved as well, since the poser.pugx.org cannot find the
wp-coding-standards/wpcsrepository when you search for it (although it seems to be pulling the information correctly). I guess that would be a big breaking change for all the people who are using WPCS in their standards.