Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Part name is only updated after saving changes #29844

Open
annezazu opened this issue Mar 12, 2021 · 2 comments
Open

Template Part name is only updated after saving changes #29844

annezazu opened this issue Mar 12, 2021 · 2 comments

Comments

@annezazu
Copy link
Contributor

@annezazu annezazu commented Mar 12, 2021

Description

When creating a new template part and adding a name, the name is not reflected on the template part until changes are saved. This came up as part of the third call for testing for the FSE Outreach Program.

Step-by-step reproduction instructions

  1. Setup an FSE site
  2. Add a template part block
  3. Use the settings options to rename the template part
  4. Notice the template part name isn't updated until one Updates Design and goes through the saving flow.

Expected behaviour

I expect the new name to show up as the name of the template part block.

Actual behaviour

The name does not update.

Screenshots or screen recording (optional)

template.naming.mov

WordPress information

  • WordPress version: 5.7
  • Gutenberg version: 10.1.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? TT1 Blocks
@annezazu
Copy link
Contributor Author

@annezazu annezazu commented Mar 22, 2021

Pulling in more feedback from the call for testing from @getdave on this current experience:

Updating the Template Part Title under Advanced didn’t update the block toolbar or the list view name for the block. I expected this to show up immediately. Once I saved the template and the template part and then refreshed the page the title did eventually show up in those locations. In fact, it looks like both List view and Block toolbar components need to be force-rerendered in order to reflect the changes. Indeed, hovering over either one once the Title is updated will cause the change to be reflected which I believe is due to the re-render occuring.

@annezazu
Copy link
Contributor Author

@annezazu annezazu commented Mar 23, 2021

Sharing more feedback from another participant in the call for testing:

When adding and naming the Template part, I can’t tell if the part has been saved and has the new name as there is no visual sign that a part of the template is there at all. That can be very confusing. I ended up with four Parts of template blocks, all stacked up and pretty much overlapping.

There were two participants who ended up with multiple template parts while testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant