Deprecating wp_clone() causes some BC Issues

[technosailor]

Notably, with the W3 Total Cache plugin. Normally, I'd say we shouldn't worry too much about plugin compatibility, but considering the widespread use of this particular one, we should consider ensuring compatibility.

I've not paid too close attention to the process of deprecation and keeping code BC. Happy to write this patch with some guidance/feedback though.

Errors from logs below for context:

[Thu Apr 21 12:53:11 2011] [error] [client 24.35.200.175] PHP Fatal error: Call to undefined function wp_clone() in /nas/wp/www/sites/aaronbrazell/wp-content/plugins/w3-total-cache/lib/W3/ObjectCache.php on line 223

[ocean90]

Related: r17613, #16813

[duck_]

We could move it back to load.php and leave as deprecated. I doubt we want to suddenly start loading it later as it was probably early for a reason.

[technosailor]

I'm okay with this. Not really sure what the point of deprecating it was anyway, besides dropping PHP4 compat.

[ryan]

It was loaded early for just this reason. I moved it to deprecated.php after auditing a bunch of object caches and not seeing any uses of wp_clone(). I obviously forgot this one. Let's put it back in load.php and leave as deprecated, as suggested by duck_.

[technosailor]

Moves deprecated wp_clone() function back to load.php

[ryan]

(In [17681]) Move wp_clone() back to load.php. Props technosailor. fixes #17206

[nacin]

In [18293]:

Avoid _deprecated_function() in wp_clone(). An object cache gets loaded before i18n functions exist. Maybe a better solution in 3.3. see #17206.