Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating custom block templates in classic themes #30438

Open
wants to merge 7 commits into
base: trunk
from

Conversation

@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Apr 1, 2021

The idea of this PR is to allow creating custom block templates (starting blank) for a given page in classic themes. It's a way for classic themes to enable some FSE features without any change.

How to test it

It's very rough at the moment, more a POC, but here's how you do it:

  • Create a new page
  • Save it
  • you'll notice on the Document sidebar, a "Create custom template" link
  • Once you click that link a custom block template is created and attached to the page.
  • By default that template Is composed by just two blocks (post title and post content) but you can edit as you wish
  • Apply the changes and publish

Now, on the frontend, your page is using its own custom template and not the regular page.php or singular.php that comes from the theme itself.

Notes

This PR can be seen as a migration strategy for classic themes, it highlights a few things in terms of code/architecture:

  • The is_fse_theme checks become less important as this blurs the line between classic and FSE themes, the whole FSE infrastructure (template post type, template resolution, template API) need to be available for classic themes too.
  • In terms of design it's very rough at the moment, we need to improve that. I'm looking at you designers :P @jasmussen @jameskoster
  • All FSE blocks become available for classic themes with this PR, this means if we ship this to Core, we need to make some good decisions about which FSE blocks are considered stable.
  • Right now, it's enable for all classic themes by default, we might want to introduce a theme support flag for it to make it opt-in.

Todo

  • Allow setting titles when creating custom templates.
  • Improve the design a bit.
  • Write an e2e test.
  • Add some documentation.
  • Theme support flag.
@github-actions
Copy link

@github-actions github-actions bot commented Apr 1, 2021

Size Change: +1.2 kB (0%)

Total Size: 1.42 MB

Filename Size Change
build/annotations/index.js 3.79 kB +5 B (0%)
build/api-fetch/index.js 3.41 kB -5 B (0%)
build/autop/index.js 2.82 kB +3 B (0%)
build/block-directory/index.js 8.63 kB -2 B (0%)
build/block-editor/index.js 127 kB -8 B (0%)
build/block-editor/style-rtl.css 12.4 kB +4 B (0%)
build/block-editor/style.css 12.4 kB +5 B (0%)
build/block-library/blocks/button/style-rtl.css 489 B -62 B (-11%) 👏
build/block-library/blocks/button/style.css 488 B -63 B (-11%) 👏
build/block-library/blocks/buttons/style-rtl.css 364 B -6 B (-2%)
build/block-library/blocks/buttons/style.css 363 B -7 B (-2%)
build/block-library/blocks/search/editor-rtl.css 189 B +24 B (+15%) ⚠️
build/block-library/blocks/search/editor.css 189 B +24 B (+15%) ⚠️
build/block-library/blocks/search/style-rtl.css 359 B +17 B (+5%) 🔍
build/block-library/blocks/search/style.css 362 B +18 B (+5%) 🔍
build/block-library/editor-rtl.css 9.54 kB +7 B (0%)
build/block-library/editor.css 9.53 kB +5 B (0%)
build/block-library/index.js 151 kB +20 B (0%)
build/block-library/style-rtl.css 9.21 kB -38 B (0%)
build/block-library/style.css 9.22 kB -38 B (0%)
build/block-serialization-default-parser/index.js 1.87 kB +3 B (0%)
build/blocks/index.js 48.4 kB -1 B (0%)
build/components/index.js 284 kB +22 B (0%)
build/core-data/index.js 17.1 kB +476 B (+3%)
build/customize-widgets/index.js 7.28 kB -2 B (0%)
build/data-controls/index.js 835 B -1 B (0%)
build/data/index.js 8.89 kB -1 B (0%)
build/edit-navigation/index.js 17 kB -326 B (-2%)
build/edit-post/index.js 307 kB +969 B (0%)
build/edit-site/index.js 28 kB +567 B (+2%)
build/edit-site/style-rtl.css 4.61 kB +31 B (+1%)
build/edit-site/style.css 4.61 kB +32 B (+1%)
build/edit-widgets/index.js 15.7 kB +34 B (0%)
build/editor/index.js 42.2 kB -505 B (-1%)
build/keyboard-shortcuts/index.js 2.53 kB -1 B (0%)
build/keycodes/index.js 1.96 kB -1 B (0%)
build/list-reusable-blocks/index.js 3.19 kB -1 B (0%)
build/media-utils/index.js 5.38 kB +1 B (0%)
build/notices/index.js 1.85 kB +1 B (0%)
build/plugins/index.js 2.95 kB -1 B (0%)
build/primitives/index.js 1.42 kB +1 B (0%)
build/react-i18n/index.js 1.46 kB +2 B (0%)
build/reusable-blocks/index.js 3.79 kB -4 B (0%)
build/rich-text/index.js 13.5 kB -2 B (0%)
build/server-side-render/index.js 2.59 kB -4 B (0%)
build/url/index.js 3.02 kB +2 B (0%)
build/viewport/index.js 1.86 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/blob/index.js 664 B 0 B
build/block-directory/style-rtl.css 1 kB 0 B
build/block-directory/style.css 1.01 kB 0 B
build/block-library/blocks/archives/editor-rtl.css 61 B 0 B
build/block-library/blocks/archives/editor.css 60 B 0 B
build/block-library/blocks/audio/editor-rtl.css 58 B 0 B
build/block-library/blocks/audio/editor.css 58 B 0 B
build/block-library/blocks/audio/style-rtl.css 112 B 0 B
build/block-library/blocks/audio/style.css 112 B 0 B
build/block-library/blocks/block/editor-rtl.css 161 B 0 B
build/block-library/blocks/block/editor.css 161 B 0 B
build/block-library/blocks/button/editor-rtl.css 475 B 0 B
build/block-library/blocks/button/editor.css 474 B 0 B
build/block-library/blocks/buttons/editor-rtl.css 315 B 0 B
build/block-library/blocks/buttons/editor.css 315 B 0 B
build/block-library/blocks/calendar/style-rtl.css 208 B 0 B
build/block-library/blocks/calendar/style.css 208 B 0 B
build/block-library/blocks/categories/editor-rtl.css 84 B 0 B
build/block-library/blocks/categories/editor.css 83 B 0 B
build/block-library/blocks/categories/style-rtl.css 79 B 0 B
build/block-library/blocks/categories/style.css 79 B 0 B
build/block-library/blocks/code/style-rtl.css 90 B 0 B
build/block-library/blocks/code/style.css 90 B 0 B
build/block-library/blocks/columns/editor-rtl.css 190 B 0 B
build/block-library/blocks/columns/editor.css 190 B 0 B
build/block-library/blocks/columns/style-rtl.css 436 B 0 B
build/block-library/blocks/columns/style.css 435 B 0 B
build/block-library/blocks/cover/editor-rtl.css 605 B 0 B
build/block-library/blocks/cover/editor.css 605 B 0 B
build/block-library/blocks/cover/style-rtl.css 1.24 kB 0 B
build/block-library/blocks/cover/style.css 1.24 kB 0 B
build/block-library/blocks/embed/editor-rtl.css 486 B 0 B
build/block-library/blocks/embed/editor.css 486 B 0 B
build/block-library/blocks/embed/style-rtl.css 401 B 0 B
build/block-library/blocks/embed/style.css 400 B 0 B
build/block-library/blocks/file/editor-rtl.css 175 B 0 B
build/block-library/blocks/file/editor.css 174 B 0 B
build/block-library/blocks/file/style-rtl.css 248 B 0 B
build/block-library/blocks/file/style.css 248 B 0 B
build/block-library/blocks/freeform/editor-rtl.css 2.45 kB 0 B
build/block-library/blocks/freeform/editor.css 2.45 kB 0 B
build/block-library/blocks/gallery/editor-rtl.css 704 B 0 B
build/block-library/blocks/gallery/editor.css 705 B 0 B
build/block-library/blocks/gallery/style-rtl.css 1.11 kB 0 B
build/block-library/blocks/gallery/style.css 1.1 kB 0 B
build/block-library/blocks/group/editor-rtl.css 160 B 0 B
build/block-library/blocks/group/editor.css 160 B 0 B
build/block-library/blocks/group/style-rtl.css 57 B 0 B
build/block-library/blocks/group/style.css 57 B 0 B
build/block-library/blocks/heading/editor-rtl.css 129 B 0 B
build/block-library/blocks/heading/editor.css 129 B 0 B
build/block-library/blocks/heading/style-rtl.css 76 B 0 B
build/block-library/blocks/heading/style.css 76 B 0 B
build/block-library/blocks/html/editor-rtl.css 281 B 0 B
build/block-library/blocks/html/editor.css 281 B 0 B
build/block-library/blocks/image/editor-rtl.css 717 B 0 B
build/block-library/blocks/image/editor.css 716 B 0 B
build/block-library/blocks/image/style-rtl.css 476 B 0 B
build/block-library/blocks/image/style.css 478 B 0 B
build/block-library/blocks/latest-comments/style-rtl.css 281 B 0 B
build/block-library/blocks/latest-comments/style.css 282 B 0 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B 0 B
build/block-library/blocks/latest-posts/editor.css 137 B 0 B
build/block-library/blocks/latest-posts/style-rtl.css 523 B 0 B
build/block-library/blocks/latest-posts/style.css 522 B 0 B
build/block-library/blocks/legacy-widget/editor-rtl.css 398 B 0 B
build/block-library/blocks/legacy-widget/editor.css 399 B 0 B
build/block-library/blocks/list/style-rtl.css 63 B 0 B
build/block-library/blocks/list/style.css 63 B 0 B
build/block-library/blocks/media-text/editor-rtl.css 191 B 0 B
build/block-library/blocks/media-text/editor.css 191 B 0 B
build/block-library/blocks/media-text/style-rtl.css 535 B 0 B
build/block-library/blocks/media-text/style.css 532 B 0 B
build/block-library/blocks/more/editor-rtl.css 434 B 0 B
build/block-library/blocks/more/editor.css 434 B 0 B
build/block-library/blocks/navigation-link/editor-rtl.css 597 B 0 B
build/block-library/blocks/navigation-link/editor.css 597 B 0 B
build/block-library/blocks/navigation-link/style-rtl.css 957 B 0 B
build/block-library/blocks/navigation-link/style.css 955 B 0 B
build/block-library/blocks/navigation/editor-rtl.css 1.13 kB 0 B
build/block-library/blocks/navigation/editor.css 1.13 kB 0 B
build/block-library/blocks/navigation/style-rtl.css 204 B 0 B
build/block-library/blocks/navigation/style.css 205 B 0 B
build/block-library/blocks/nextpage/editor-rtl.css 395 B 0 B
build/block-library/blocks/nextpage/editor.css 395 B 0 B
build/block-library/blocks/page-list/editor-rtl.css 170 B 0 B
build/block-library/blocks/page-list/editor.css 170 B 0 B
build/block-library/blocks/page-list/style-rtl.css 167 B 0 B
build/block-library/blocks/page-list/style.css 167 B 0 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B 0 B
build/block-library/blocks/paragraph/editor.css 157 B 0 B
build/block-library/blocks/paragraph/style-rtl.css 247 B 0 B
build/block-library/blocks/paragraph/style.css 248 B 0 B
build/block-library/blocks/post-author/editor-rtl.css 209 B 0 B
build/block-library/blocks/post-author/editor.css 209 B 0 B
build/block-library/blocks/post-author/style-rtl.css 183 B 0 B
build/block-library/blocks/post-author/style.css 184 B 0 B
build/block-library/blocks/post-comments-form/style-rtl.css 250 B 0 B
build/block-library/blocks/post-comments-form/style.css 250 B 0 B
build/block-library/blocks/post-content/editor-rtl.css 139 B 0 B
build/block-library/blocks/post-content/editor.css 139 B 0 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B 0 B
build/block-library/blocks/post-excerpt/editor.css 73 B 0 B
build/block-library/blocks/post-featured-image/editor-rtl.css 338 B 0 B
build/block-library/blocks/post-featured-image/editor.css 338 B 0 B
build/block-library/blocks/post-featured-image/style-rtl.css 100 B 0 B
build/block-library/blocks/post-featured-image/style.css 100 B 0 B
build/block-library/blocks/preformatted/style-rtl.css 103 B 0 B
build/block-library/blocks/preformatted/style.css 103 B 0 B
build/block-library/blocks/pullquote/editor-rtl.css 183 B 0 B
build/block-library/blocks/pullquote/editor.css 183 B 0 B
build/block-library/blocks/pullquote/style-rtl.css 318 B 0 B
build/block-library/blocks/pullquote/style.css 318 B 0 B
build/block-library/blocks/query-loop/editor-rtl.css 83 B 0 B
build/block-library/blocks/query-loop/editor.css 82 B 0 B
build/block-library/blocks/query-loop/style-rtl.css 315 B 0 B
build/block-library/blocks/query-loop/style.css 317 B 0 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B 0 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B 0 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B 0 B
build/block-library/blocks/query-pagination/editor.css 262 B 0 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B 0 B
build/block-library/blocks/query-pagination/style.css 168 B 0 B
build/block-library/blocks/query-title/editor-rtl.css 86 B 0 B
build/block-library/blocks/query-title/editor.css 86 B 0 B
build/block-library/blocks/query/editor-rtl.css 795 B 0 B
build/block-library/blocks/query/editor.css 794 B 0 B
build/block-library/blocks/quote/style-rtl.css 169 B 0 B
build/block-library/blocks/quote/style.css 169 B 0 B
build/block-library/blocks/rss/editor-rtl.css 201 B 0 B
build/block-library/blocks/rss/editor.css 202 B 0 B
build/block-library/blocks/rss/style-rtl.css 290 B 0 B
build/block-library/blocks/rss/style.css 290 B 0 B
build/block-library/blocks/separator/editor-rtl.css 99 B 0 B
build/block-library/blocks/separator/editor.css 99 B 0 B
build/block-library/blocks/separator/style-rtl.css 251 B 0 B
build/block-library/blocks/separator/style.css 251 B 0 B
build/block-library/blocks/shortcode/editor-rtl.css 512 B 0 B
build/block-library/blocks/shortcode/editor.css 512 B 0 B
build/block-library/blocks/site-logo/editor-rtl.css 201 B 0 B
build/block-library/blocks/site-logo/editor.css 201 B 0 B
build/block-library/blocks/site-logo/style-rtl.css 115 B 0 B
build/block-library/blocks/site-logo/style.css 115 B 0 B
build/block-library/blocks/social-link/editor-rtl.css 164 B 0 B
build/block-library/blocks/social-link/editor.css 165 B 0 B
build/block-library/blocks/social-links/editor-rtl.css 776 B 0 B
build/block-library/blocks/social-links/editor.css 776 B 0 B
build/block-library/blocks/social-links/style-rtl.css 1.32 kB 0 B
build/block-library/blocks/social-links/style.css 1.33 kB 0 B
build/block-library/blocks/spacer/editor-rtl.css 317 B 0 B
build/block-library/blocks/spacer/editor.css 317 B 0 B
build/block-library/blocks/spacer/style-rtl.css 48 B 0 B
build/block-library/blocks/spacer/style.css 48 B 0 B
build/block-library/blocks/table/editor-rtl.css 478 B 0 B
build/block-library/blocks/table/editor.css 478 B 0 B
build/block-library/blocks/table/style-rtl.css 402 B 0 B
build/block-library/blocks/table/style.css 402 B 0 B
build/block-library/blocks/tag-cloud/editor-rtl.css 118 B 0 B
build/block-library/blocks/tag-cloud/editor.css 118 B 0 B
build/block-library/blocks/tag-cloud/style-rtl.css 94 B 0 B
build/block-library/blocks/tag-cloud/style.css 94 B 0 B
build/block-library/blocks/template-part/editor-rtl.css 552 B 0 B
build/block-library/blocks/template-part/editor.css 551 B 0 B
build/block-library/blocks/term-description/editor-rtl.css 90 B 0 B
build/block-library/blocks/term-description/editor.css 90 B 0 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B 0 B
build/block-library/blocks/text-columns/editor.css 95 B 0 B
build/block-library/blocks/text-columns/style-rtl.css 166 B 0 B
build/block-library/blocks/text-columns/style.css 166 B 0 B
build/block-library/blocks/verse/editor-rtl.css 50 B 0 B
build/block-library/blocks/verse/editor.css 50 B 0 B
build/block-library/blocks/verse/style-rtl.css 87 B 0 B
build/block-library/blocks/verse/style.css 87 B 0 B
build/block-library/blocks/video/editor-rtl.css 504 B 0 B
build/block-library/blocks/video/editor.css 503 B 0 B
build/block-library/blocks/video/style-rtl.css 187 B 0 B
build/block-library/blocks/video/style.css 187 B 0 B
build/block-library/common-rtl.css 1.31 kB 0 B
build/block-library/common.css 1.31 kB 0 B
build/block-library/reset-rtl.css 503 B 0 B
build/block-library/reset.css 504 B 0 B
build/block-library/theme-rtl.css 692 B 0 B
build/block-library/theme.css 693 B 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/components/style-rtl.css 16.2 kB 0 B
build/components/style.css 16.2 kB 0 B
build/compose/index.js 11.2 kB 0 B
build/customize-widgets/style-rtl.css 676 B 0 B
build/customize-widgets/style.css 677 B 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 787 B 0 B
build/dom-ready/index.js 576 B 0 B
build/dom/index.js 5.08 kB 0 B
build/edit-navigation/style-rtl.css 2.86 kB 0 B
build/edit-navigation/style.css 2.86 kB 0 B
build/edit-post/style-rtl.css 7.13 kB 0 B
build/edit-post/style.css 7.12 kB 0 B
build/edit-widgets/style-rtl.css 2.98 kB 0 B
build/edit-widgets/style.css 2.98 kB 0 B
build/editor/style-rtl.css 3.96 kB 0 B
build/editor/style.css 3.96 kB 0 B
build/element/index.js 4.62 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.75 kB 0 B
build/format-library/style-rtl.css 637 B 0 B
build/format-library/style.css 639 B 0 B
build/hooks/index.js 2.28 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 4.02 kB 0 B
build/is-shallow-equal/index.js 699 B 0 B
build/list-reusable-blocks/style-rtl.css 629 B 0 B
build/list-reusable-blocks/style.css 628 B 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 731 B 0 B
build/nux/style.css 727 B 0 B
build/priority-queue/index.js 791 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/reusable-blocks/style-rtl.css 225 B 0 B
build/reusable-blocks/style.css 225 B 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

youknowriad added 2 commits Apr 1, 2021
@youknowriad youknowriad marked this pull request as ready for review Apr 2, 2021
@youknowriad
Copy link
Contributor Author

@youknowriad youknowriad commented Apr 2, 2021

This PR is not ready yet but it's ready to get thoughts and designs.

@aristath
Copy link
Member

@aristath aristath commented Apr 2, 2021

Right now, it's enable for all classic themes by default, we might want to introduce a theme support flag for it to make it opt-in.

I think that would be necessary in many situations... and it should also be filterable so users can install a plugin to enable it on their old, not-updated theme. See PR #30465 for a suggestion

@mtias mtias mentioned this pull request Apr 2, 2021
1 of 11 tasks complete
@aristath
Copy link
Member

@aristath aristath commented Apr 2, 2021

Thinking about the theme-support thing some more, perhaps it should be opt-out instead of opt-in? 🤔
IMO this is going to be one of the things that will get huge adoption by classic-theme users... It will allow them to use their theme for their site, while at the same time being able to build a completely custom frontpage if they so desire.
If we make it opt-in we'll be excluding a large portion of the userbase, but it is the "safer" choice because people just won't see the feature.
If we make it opt-out, then we are more inline with what we want the future of WP to be. If a theme doesn't want FSE for some reason, then they can explicitly define that.

I believe opt-out would make more sense... (updated the PR on #30465 to reflect that)

const template = {
slug: 'custom-template-' + uuid(),
content: serialize( templateContent ),
title: 'Custom Template',

This comment has been minimized.

@youknowriad

youknowriad Apr 2, 2021
Author Contributor

To avoid having all custom templates have the same name by default, I think we should do something similar to template parts and reusable block: show a modal when clicking the "Create custom template" link and ask the user to fill a title.

This comment has been minimized.

@aristath

aristath Apr 2, 2021
Member

A title would be useful in identifying the templates 👍

aristath added 2 commits Apr 2, 2021
* Change the prefix for custom templates

* Update comment
* Introduce gutenberg_is_fse_enabled

* typo & reverse logic

* update filter name

* Remove filter

* Rename function

* don't use "disable"theme-supports

* rename theme-support
@aristath aristath requested a review from nosolosw as a code owner Apr 2, 2021
@paaljoachim
Copy link
Contributor

@paaljoachim paaljoachim commented Apr 2, 2021

What an intriguing PR!

I am using the Twenty Twenty One theme.
I downloaded a special version of the Gutenberg plugin (Going to Checks -> clicked Gutenberg build in left sidebar -> downloaded Gutenberg plugin. Extracted and compressed it again and uploaded the special GB plugin. Additional instructions here: https://youtu.be/eJhgUjrTSF0).

Then followed the instructions added by Riad.
Create a page. I saved it as a draft. I did not see a "Create custom template" link in the sidebar. How do I proceed?

@aristath
Copy link
Member

@aristath aristath commented Apr 2, 2021

@paaljoachim That was my bad, in 6067b42 the line defining theme-support was not renamed. I pushed a fix here just now so once the build finishes you'll be able to test it 👍
If you don't want to wait for the build, you could add in your functions.php file add_theme_support( 'block-templates' );

@paaljoachim
Copy link
Contributor

@paaljoachim paaljoachim commented Apr 2, 2021

Great! In addition to using the special Gutenberg plugin mentioned above I then added the code snippet to the functions file add_theme_support( 'block-templates' );

My test.

1.I would suggest a developer create a PR for moving the page/post title to the top bar. It would also be one of the many connections with Full Site Editing. #27093

As having the title in the top bar. Be it "Page content: Page title", "Content: Page title" or just the "Page title".
Would right away create a connection with using templates.

For this PR where I test page templates.
One should then see the page title in the top bar. Click the Create custom template" Then in the top bar see
Template: Page title. Having the Template: Page title in the top bar gives a nice signal to the user where they are.
Here is a mockup where I added the "Custom template: Test template" to the top bar and "Custom template: Document" to the bottom breadcrumbs. Having multiple ways for the user to see where they are. (In addition to seeing the word template and template name in the sidebar settings.)

Custom-template

2.Save or do not save is the question. Save or discard a save.
User clicks "Apply" and notices the prechecked Custom Template.

Screen Shot 2021-04-02 at 16 34 23

What if the user decides not to save?
They see this:

Screen Shot 2021-04-02 at 16 35 20

A greyed out blue button. User it not able to move onward, and meets a dead end.
An alternative suggestion would be as seen in this comment:
#29577 (comment)

Which basically does this:
Discard-custom-template-save

The user makes a selection if they want or do not want to save the custom template. Perhaps they just wanted to see what it is without saving. If they decide not to save they become stuck in the custom template. Having no obvious way on how to get back to the regular page. Perhaps they click the Page tab and look at Status & visibility to see if there is a bridge back to the page content in the same place they clicked to "Create a custom template" but there is none. So the user is forced to save.

Screen Shot 2021-04-02 at 16 44 00

Going back to the page content. It looks like this...

Screen Shot 2021-04-02 at 16 44 41

User might think. Why am I not seeing the template content in my page?
As it should show up similar to how a Reusable block is seen. Perhaps even use the click through method being explored here: #30156 (Actually James @jameskoster has continued to explore the click through method.) As the user would initially click the template and select the parent container. Then click into it and make changes. Then Save the change in some way. Either with a Save button in the toolbar as suggested by @critterverse Channing here: #30357 or having a save button in the sidebar settings.

Custom-template-similar-to-Reusable-block

Bottom line is that being able to add a page template is a very nice feature! Along the way before this PR is merged other PR's can be created making specific UI (top bar page title) and UX (being able to easily discard a save) making the flow easier for the general user and also for us. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants