Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handbook: Updated documentation to reflect the output created currently by npx @wordpress/create-block gutenpride #30353

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

janw-me
Copy link
Contributor

@janw-me janw-me commented Mar 29, 2021

Description

I updated the the documentation based on the output of npx @wordpress/create-block gutenpride

Types of changes

  • Updated a lot of code snippets.
  • Updated text reference to those code snippets.

There is one section I made real changes. I deleted the Use Sass for Style section.And I updated the instructions to include the compilation.
My reasoning is as following; In previous steps we did explain building, to get here a user already should have build the plugin at least once.The file names of the sass files are a lot more clear. Even if a user does not know sass the example code only uses normal css, and normal css is save to enter in sass.

I hope this entry gets accepted.

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @janw-me! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 29, 2021
@janw-me
Copy link
Contributor Author

janw-me commented Mar 29, 2021

@mkaz As we talked about last week, I updated the docs and here is the pull.
Please review and let me know.

Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janw-me This is great work, thank you so much for your time updating the tutorial with the latest. I walked through it all and it looks good.

I think you're right simplifying the SCSS part since it's already discussed in the build, this change recently to be a default, so it was another area a little outdated.

Thanks again, great first contribution 👍

@mkaz mkaz merged commit adc0b38 into WordPress:trunk Mar 30, 2021
@github-actions
Copy link

Congratulations on your first merged pull request, @janw-me! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@gziolo
Copy link
Member

gziolo commented Mar 30, 2021

That's fantastic work, thank you for bringing this tutorial up to date 👏🏻

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Mar 30, 2021
@janw-me
Copy link
Contributor Author

janw-me commented Mar 30, 2021

Thanks for accepting my edits.
I see it's already live 🎉

@gziolo gziolo changed the title Updated documentation to reflect the output created currently by npx @wordpress/create-block gutenpride Handbook: Updated documentation to reflect the output created currently by npx @wordpress/create-block gutenpride Apr 6, 2021
@gziolo gziolo added the [Package] Create Block /packages/create-block label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Create Block /packages/create-block [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants