Skip to content

/ GlotPress-WP

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misspelled action and incorrect comment in GP_Original::closest_original() #729

Closed
SergeyBiryukov opened this issue Jun 3, 2017 · 3 comments
Closed

Misspelled action and incorrect comment in GP_Original::closest_original() #729

SergeyBiryukov opened this issue Jun 3, 2017 · 3 comments
Assignees
@SergeyBiryukov
Labels
[Status] In Progress [Type] Bug
Milestone
3.0

Comments

@SergeyBiryukov
Copy link
Member

@SergeyBiryukov SergeyBiryukov commented Jun 3, 2017

Found two issues in GP_Original::closest_original():

  • The gp_post_string_similiary_test action is misspelled, I think it should be gp_post_string_similarity_test.
  • The comment says: "Fires before determining string similarity", but it fires after determining the similarity, not before.
SergeyBiryukov added a commit to SergeyBiryukov/GlotPress-WP that referenced this issue Jun 3, 2017
@SergeyBiryukov
Correct 'gp_post_string_similarity_test' action name and comment
b31949d 
Fixes GlotPress#729.
SergeyBiryukov added a commit to SergeyBiryukov/GlotPress-WP that referenced this issue Jun 3, 2017
@SergeyBiryukov
Correct 'gp_post_string_similarity_test' action name and comment
31bceee 
Fixes GlotPress#729.
@SergeyBiryukov SergeyBiryukov mentioned this issue Jun 3, 2017
Merged
@ocean90
Copy link
Member

@ocean90 ocean90 commented Jun 7, 2017

Introduced in https://glotpress.trac.wordpress.org/changeset/1032.

@yoavf Does wp.com use the action?
@toolstack toolstack added this to the 3.0 milestone Jun 23, 2017
@toolstack
Copy link
Contributor

@toolstack toolstack commented Jun 23, 2017

I added the 3.0 milestone to this as it is an API breaking change.

Otherwise it looks good to me.
@yoavf
Copy link
Member

@yoavf yoavf commented Jun 25, 2017 •
edited

@yoavf Does wp.com use the action?

I don't think we are. Thanks for catching this @SergeyBiryukov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyBiryukov SergeyBiryukov

Labels
[Status] In Progress [Type] Bug
Projects
None yet
Milestone
3.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@SergeyBiryukov @ocean90 @yoavf @toolstack