Twenty Twenty: remove aria-expanded on Close Search button

[alexstine]

Theme: Twenty Twenty

When opening the search form in the header, the Search button automatically gets aria-expanded toggled. However, on the Close Search button, aria-expanded="false" is set by default. Need to remove this attribute as Close Search does not toggle any behavior, it is simply a regular button to close the search form.

https://core.trac.wordpress.org/ticket/52355#comment:1

[alexstine]

This is ready for testing.

To test:

1. Activate Twenty Twenty theme.
2. Apply this patch.
3. Select Search.
4. Select Close Search.
5. Check HTML via inspector to make sure aria-expanded="true/false" does not exist on Close Search button.

Thanks.

[audrasjb]

Before: aria-expanded attribute is toggled on click on the close button

[audrasjb]

After patch: no aria-expanded attribute is used anymore

[audrasjb]

Hi @alexstine, I tested your patch. It works fine and sounds legit to me.
Above, I shared two animated screenshot to demonstrate that your patch fixes the issue.
Looks good to go on my side. Removing needs-testing workflow keyword and replacing it with commit :-)

[joedolson]

In 50033:

Twenty Twenty: Remove aria-expanded on search modal close button.

The Twenty Twenty search modal uses aria-expanded correctly on the Search button, but toggles the aria-expanded value on the 'close' button. The close button is a different control, however, so the attribute value toggling is uneven. The close button does not toggle any behavior; it only closes a control that has already been opened.

Props alexstine, audrasjb
Fixes #52355

[prbot]

​hellofromtonya commented on ​PR #918:

Ticket closed with changeset https://core.trac.wordpress.org/changeset/50033