WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#38357 closed enhancement (fixed)

Replace get_blog_details() usage in ms_site_check() with get_site()

Reported by: iamfriendly Owned by: jeremyfelt
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.6
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:

Description

See https://core.trac.wordpress.org/ticket/37102#comment:17

Number 23 from original ticket.

Could add unit tests to ms_site_check() at the same time.

Attachments (1)

38357.diff​ (717 bytes) - added by flixos90 4 years ago.

Download all attachments as: .zip

Change History (6)

#1 @flixos90
4 years ago

  • Keywords needs-patch needs-unit-tests added

@flixos90
4 years ago

#2 follow-up: @flixos90
4 years ago

  • Keywords has-patch added; needs-patch needs-unit-tests removed
  • Milestone changed from Awaiting Review to 4.7
  • Owner set to jeremyfelt
  • Status changed from new to assigned

38357.diff​ replaces get_blog_details() with get_site() in ms_site_check(). Regarding unit tests, after looking at the function I don't think we can properly test this function at this point, so I would skip that for now.

This ticket was mentioned in ​Slack in #core by jeffpaul. ​View the logs.
4 years ago

#4 in reply to: ↑ 2 @jeremyfelt
4 years ago

Replying to flixos90:

Regarding unit tests, after looking at the function I don't think we can properly test this function at this point, so I would skip that for now.

Agreed.

#5 @jeremyfelt
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38904:

Multisite: Replace get_blog_details() in ms_site_check() with get_site().

Props flixos90.
Fixes #38357.

Note: See TracTickets for help on using tickets.