WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#38355 closed enhancement (fixed)

Replace get_blog_details() usage in get_active_blog_for_user() with get_site()

Reported by: iamfriendly Owned by: jeremyfelt
Milestone: 4.7 Priority: normal
Severity: normal Version: 3.0
Component: Networks and Sites Keywords: has-patch has-unit-tests
Focuses: multisite Cc:

Description

See https://core.trac.wordpress.org/ticket/37102#comment:17

Numbers 19, 20, and 21 from original ticket.

Should probably include unit tests for get_active_blog_for_user()

Attachments (3)

38355.diff​ (1.1 KB) - added by dipesh.kakadiya 4 years ago.
38355.2.diff​ (3.4 KB) - added by flixos90 4 years ago.
38355.3.diff​ (3.6 KB) - added by jeremyfelt 4 years ago.

Download all attachments as: .zip

Change History (9)

@dipesh.kakadiya
4 years ago

#1 @flixos90
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.7
  • Owner set to jeremyfelt
  • Status changed from new to assigned

Thanks for the patch @dipesh.kakadiya! Looks good to me.

@flixos90
4 years ago

#2 @flixos90
4 years ago

  • Keywords has-unit-tests added

38355.2.diff​ adds unit tests for get_active_blog_for_user().

This ticket was mentioned in ​Slack in #core by jeffpaul. ​View the logs.
4 years ago

This ticket was mentioned in ​Slack in #core-multisite by flixos90. ​View the logs.
4 years ago

@jeremyfelt
4 years ago

#5 @jeremyfelt
4 years ago

In 38913:

Multisite: Introduce tests for get_active_blog_for_user().

Props flixos90.
See #38355.

#6 @jeremyfelt
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38914:

Multisite: Replace get_blog_details() in get_active_blog_for_user() with get_site().

Props flixos90.
Fixes #38355.

Note: See TracTickets for help on using tickets.