Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Selecting a block when Settings sidebar is open, it should switch to Block tab #29372

Open
david-szabo97 opened this issue Feb 26, 2021 · 1 comment

Comments

@david-szabo97
Copy link
Member

@david-szabo97 david-szabo97 commented Feb 26, 2021

To be more consistent with Post Editor, we should consider automatically switching the sidebar between tabs based on context. We already have a feature in place that automatically switches to Block tab when opening the settings sidebar while a block is selected.

In the post editor, when we select a block (while nothing is selected), then the sidebar automatically switches from Page to Block. And vice-versa: when we remove our selection then it switches from Block to Page. I'm not sure if this is intentional though. So it might be a bug in the post editor instead of a feature. cc @mtias @jameskoster

For reference, here is how the post editor works: (Note: It doesn't switch to Block tab if we just keep changing our selection between blocks. But it does if we have nothing selected then we select something)

Screen.Recording.2021-02-26.at.11.59.01.mov

And here is how the site editor works:

Screen.Recording.2021-02-26.at.12.00.07.mov
@jameskoster
Copy link
Contributor

@jameskoster jameskoster commented Feb 26, 2021

Agreed. Also somewhat related: #29254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants