@jasmussen Hope you don't mind I started a fresh PR for this. When you get the chance can you take a look at the new control combining font style and weight options?

I'm not sure if it needs separators between the groups of weight/style combos. Also, should it be 100% width or do you see it potentially fitting in alongside other options?

Nice. This is what I see:

The names are all-caps, due to this rule it appears:

It seems that rule was intended for menu subheadings, but is a little wide-reaching. Suffice to say, the fonts should not be all-caps, and should be the usual $gray-900 font color. I also think "Heavy Italic" is more readable than "Heavy - Italic", so no need for the dash.

Other than that, this is working well, and feels obvious. 👍 👍

I've updated the control's styling so the items:

• are not all caps
• use the $gray-900 color
• do not include the hyphen in the label

Thanks for all the feedback. I think this is getting close now 🙂

I've rebased this to pull in the latest changes in approach to registering/applying block support. I think this just needs a review now to move forward.

This is cool:

I think you should sync up with @karmatosed per the opportunity outlined in #26572 (comment), it looks like you're both touching the same files, and the color, font size, all caps styles that are currently inherited, probably shouldn't be inherited at all.

I'm glad you're happy so far with the combined weight/style dropdown.

I think you should sync up with karmatosed per the opportunity outlined in #26572 (comment), it looks like you're both touching the same files, and the color, font size, all caps styles that are currently inherited, probably shouldn't be inherited at all.

Agreed. Those styles appear to be applied when they shouldn't be. I was hoping to be able to take a look at where they are actually used and tweak the CSS accordingly. I will probably do that via a separate PR though.

By the way, can you add a separator between the regular and italic weights? It's not super necessary but would be nice.

By the way, can you add a separator between the regular and italic weights? It's not super necessary but would be nice.

I initially thought it could do with a separator in there as well although I didn't find an obvious option to do that. Now, it's been brought up, I'll take another look at it next week.

My main issue was making sure that I wasn't adding another option that users could interact with or would impede accessibility. If anyone has any suggestions for doing this with a CustomSelectControl they'd be much appreciated 🙂

The separator should not block this PR.