Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: Fix inserter can't be closed #28590

Open
wants to merge 1 commit into
base: master
from
Open

Site Editor: Fix inserter can't be closed #28590

wants to merge 1 commit into from
+14 −3

Conversation

@david-szabo97
Copy link
Member

@david-szabo97 david-szabo97 commented Jan 29, 2021

Description

Clicking the inserter button in the header toolbar keeps reopening the inserter. Fixing it by the same technique that's used in the edit-post

How has this been tested?

  1. Open site editor
  2. Click on inserter button
  3. Inserter should open
  4. Click on inserter button
  5. Inserter should close

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@david-szabo97
Fix inserter can't be closed
Loading status checks…
63400fe
@david-szabo97 david-szabo97 self-assigned this Jan 29, 2021
@jeyip
Copy link
Contributor

@jeyip jeyip commented Jan 30, 2021 •
edited

Testing

Behavior

  • Clicking on the inserter button opens the inserter
  • Clicking on the inserter button again closes the inserter

Browsers

  • Chrome
  • Firefox
  • Edge
  • Safari
  • IE11
@jeyip
Copy link
Contributor

@jeyip jeyip commented Jan 30, 2021

Everything looks reasonable to me! Could we add an e2e test for this?

+1 after we resolve the discussion about tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwiebe mattwiebe

@vindl vindl

@Copons Copons

@jeyip jeyip

@Addison-Stavlo Addison-Stavlo

At least 1 approving review is required to merge this pull request.

Assignees

@david-szabo97 david-szabo97

Labels
[Feature] Full Site Editing
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@david-szabo97 @jeyip