Transform paragraph block to buttons block #28508
Open
+26
−0
Conversation
Side note: one thing we need to revise a bit is the order of transformations. Headings and List should probably come first, for example. We might also want to restrict certain transforms to the case where the length of a paragraph block is < than some characters — it doesn't make sense to convert a full paragraph with multiple lines into a button, for example. |
Maybe also checking if a paragraph has more than one links? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
hsingyuc commentedJan 27, 2021
Description
Fix #28298
Transform paragraph block to buttons block
How has this been tested?
// Test text with one link
Link in Paragraph
, clickChange block type or style
and see ifButtons
renders as expected.Buttons
and see if the text transforms into a button with the link.// Test texts with links
Link in Paragraph
, clickChange block type or style
and see ifButtons
renders as expected.Buttons
and see if the text transforms into a button with the first link (link1).// Test texts without a link
Link in Paragraph
, clickChange block type or style
and see ifButtons
renders as expected.Buttons
and see if the text transforms into a button.Screenshots
Types of changes
Checklist: