Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
E2E Tests: Document Settings #27715
Open
E2E Tests: Document Settings #27715
+103
−0
Conversation
Size Change: 0 B Total Size: 1.28 MB
|
Filename | Size | Change | |
---|---|---|---|
build/a11y/index.js |
1.14 kB | 0 B | |
build/annotations/index.js |
3.81 kB | 0 B | |
build/api-fetch/index.js |
3.42 kB | 0 B | |
build/autop/index.js |
2.83 kB | 0 B | |
build/blob/index.js |
665 B | 0 B | |
build/block-directory/index.js |
8.72 kB | 0 B | |
build/block-directory/style-rtl.css |
943 B | 0 B | |
build/block-directory/style.css |
942 B | 0 B | |
build/block-editor/index.js |
128 kB | 0 B | |
build/block-editor/style-rtl.css |
11.2 kB | 0 B | |
build/block-editor/style.css |
11.2 kB | 0 B | |
build/block-library/blocks/archives/editor-rtl.css |
120 B | 0 B | |
build/block-library/blocks/archives/editor.css |
119 B | 0 B | |
build/block-library/blocks/audio/editor-rtl.css |
118 B | 0 B | |
build/block-library/blocks/audio/editor.css |
118 B | 0 B | |
build/block-library/blocks/audio/style-rtl.css |
152 B | 0 B | |
build/block-library/blocks/audio/style.css |
152 B | 0 B | |
build/block-library/blocks/block/editor-rtl.css |
211 B | 0 B | |
build/block-library/blocks/block/editor.css |
211 B | 0 B | |
build/block-library/blocks/button/editor-rtl.css |
513 B | 0 B | |
build/block-library/blocks/button/editor.css |
513 B | 0 B | |
build/block-library/blocks/button/style-rtl.css |
488 B | 0 B | |
build/block-library/blocks/button/style.css |
488 B | 0 B | |
build/block-library/blocks/buttons/editor-rtl.css |
275 B | 0 B | |
build/block-library/blocks/buttons/editor.css |
275 B | 0 B | |
build/block-library/blocks/buttons/style-rtl.css |
346 B | 0 B | |
build/block-library/blocks/buttons/style.css |
346 B | 0 B | |
build/block-library/blocks/calendar/style-rtl.css |
249 B | 0 B | |
build/block-library/blocks/calendar/style.css |
249 B | 0 B | |
build/block-library/blocks/categories/editor-rtl.css |
135 B | 0 B | |
build/block-library/blocks/categories/editor.css |
135 B | 0 B | |
build/block-library/blocks/categories/style-rtl.css |
132 B | 0 B | |
build/block-library/blocks/categories/style.css |
132 B | 0 B | |
build/block-library/blocks/code/style-rtl.css |
152 B | 0 B | |
build/block-library/blocks/code/style.css |
152 B | 0 B | |
build/block-library/blocks/columns/editor-rtl.css |
239 B | 0 B | |
build/block-library/blocks/columns/editor.css |
239 B | 0 B | |
build/block-library/blocks/columns/style-rtl.css |
467 B | 0 B | |
build/block-library/blocks/columns/style.css |
466 B | 0 B | |
build/block-library/blocks/cover/editor-rtl.css |
440 B | 0 B | |
build/block-library/blocks/cover/editor.css |
438 B | 0 B | |
build/block-library/blocks/cover/style-rtl.css |
1.27 kB | 0 B | |
build/block-library/blocks/cover/style.css |
1.27 kB | 0 B | |
build/block-library/blocks/embed/editor-rtl.css |
529 B | 0 B | |
build/block-library/blocks/embed/editor.css |
529 B | 0 B | |
build/block-library/blocks/embed/style-rtl.css |
419 B | 0 B | |
build/block-library/blocks/embed/style.css |
419 B | 0 B | |
build/block-library/blocks/file/editor-rtl.css |
246 B | 0 B | |
build/block-library/blocks/file/editor.css |
245 B | 0 B | |
build/block-library/blocks/file/style-rtl.css |
288 B | 0 B | |
build/block-library/blocks/file/style.css |
289 B | 0 B | |
build/block-library/blocks/freeform/editor-rtl.css |
2.49 kB | 0 B | |
build/block-library/blocks/freeform/editor.css |
2.49 kB | 0 B | |
build/block-library/blocks/gallery/editor-rtl.css |
692 B | 0 B | |
build/block-library/blocks/gallery/editor.css |
693 B | 0 B | |
build/block-library/blocks/gallery/style-rtl.css |
1.11 kB | 0 B | |
build/block-library/blocks/gallery/style.css |
1.11 kB | 0 B | |
build/block-library/blocks/group/editor-rtl.css |
364 B | 0 B | |
build/block-library/blocks/group/editor.css |
364 B | 0 B | |
build/block-library/blocks/group/style-rtl.css |
117 B | 0 B | |
build/block-library/blocks/group/style.css |
117 B | 0 B | |
build/block-library/blocks/heading/editor-rtl.css |
174 B | 0 B | |
build/block-library/blocks/heading/editor.css |
174 B | 0 B | |
build/block-library/blocks/heading/style-rtl.css |
137 B | 0 B | |
build/block-library/blocks/heading/style.css |
137 B | 0 B | |
build/block-library/blocks/html/editor-rtl.css |
324 B | 0 B | |
build/block-library/blocks/html/editor.css |
325 B | 0 B | |
build/block-library/blocks/image/editor-rtl.css |
738 B | 0 B | |
build/block-library/blocks/image/editor.css |
737 B | 0 B | |
build/block-library/blocks/image/style-rtl.css |
510 B | 0 B | |
build/block-library/blocks/image/style.css |
511 B | 0 B | |
build/block-library/blocks/latest-comments/editor-rtl.css |
201 B | 0 B | |
build/block-library/blocks/latest-comments/editor.css |
200 B | 0 B | |
build/block-library/blocks/latest-comments/style-rtl.css |
315 B | 0 B | |
build/block-library/blocks/latest-comments/style.css |
315 B | 0 B | |
build/block-library/blocks/latest-posts/editor-rtl.css |
183 B | 0 B | |
build/block-library/blocks/latest-posts/editor.css |
183 B | 0 B | |
build/block-library/blocks/latest-posts/style-rtl.css |
568 B | 0 B | |
build/block-library/blocks/latest-posts/style.css |
567 B | 0 B | |
build/block-library/blocks/list/editor-rtl.css |
129 B | 0 B | |
build/block-library/blocks/list/editor.css |
129 B | 0 B | |
build/block-library/blocks/list/style-rtl.css |
127 B | 0 B | |
build/block-library/blocks/list/style.css |
127 B | 0 B | |
build/block-library/blocks/media-text/editor-rtl.css |
240 B | 0 B | |
build/block-library/blocks/media-text/editor.css |
240 B | 0 B | |
build/block-library/blocks/media-text/style-rtl.css |
579 B | 0 B | |
build/block-library/blocks/media-text/style.css |
577 B | 0 B | |
build/block-library/blocks/more/editor-rtl.css |
479 B | 0 B | |
build/block-library/blocks/more/editor.css |
479 B | 0 B | |
build/block-library/blocks/navigation-link/editor-rtl.css |
438 B | 0 B | |
build/block-library/blocks/navigation-link/editor.css |
440 B | 0 B | |
build/block-library/blocks/navigation-link/style-rtl.css |
747 B | 0 B | |
build/block-library/blocks/navigation-link/style.css |
745 B | 0 B | |
build/block-library/blocks/navigation/editor-rtl.css |
1.31 kB | 0 B | |
build/block-library/blocks/navigation/editor.css |
1.31 kB | 0 B | |
build/block-library/blocks/navigation/style-rtl.css |
222 B | 0 B | |
build/block-library/blocks/navigation/style.css |
222 B | 0 B | |
build/block-library/blocks/nextpage/editor-rtl.css |
440 B | 0 B | |
build/block-library/blocks/nextpage/editor.css |
440 B | 0 B | |
build/block-library/blocks/paragraph/editor-rtl.css |
161 B | 0 B | |
build/block-library/blocks/paragraph/editor.css |
161 B | 0 B | |
build/block-library/blocks/paragraph/style-rtl.css |
279 B | 0 B | |
build/block-library/blocks/paragraph/style.css |
279 B | 0 B | |
build/block-library/blocks/post-author/editor-rtl.css |
255 B | 0 B | |
build/block-library/blocks/post-author/editor.css |
255 B | 0 B | |
build/block-library/blocks/post-author/style-rtl.css |
229 B | 0 B | |
build/block-library/blocks/post-author/style.css |
230 B | 0 B | |
build/block-library/blocks/post-content/editor-rtl.css |
187 B | 0 B | |
build/block-library/blocks/post-content/editor.css |
187 B | 0 B | |
build/block-library/blocks/post-excerpt/editor-rtl.css |
134 B | 0 B | |
build/block-library/blocks/post-excerpt/editor.css |
134 B | 0 B | |
build/block-library/blocks/post-featured-image/editor-rtl.css |
387 B | 0 B | |
build/block-library/blocks/post-featured-image/editor.css |
386 B | 0 B | |
build/block-library/blocks/post-featured-image/style-rtl.css |
149 B | 0 B | |
build/block-library/blocks/post-featured-image/style.css |
149 B | 0 B | |
build/block-library/blocks/pullquote/editor-rtl.css |
231 B | 0 B | |
build/block-library/blocks/pullquote/editor.css |
231 B | 0 B | |
build/block-library/blocks/pullquote/style-rtl.css |
359 B | 0 B | |
build/block-library/blocks/pullquote/style.css |
359 B | 0 B | |
build/block-library/blocks/query-loop/editor-rtl.css |
142 B | 0 B | |
build/block-library/blocks/query-loop/editor.css |
141 B | 0 B | |
build/block-library/blocks/query-loop/style-rtl.css |
361 B | 0 B | |
build/block-library/blocks/query-loop/style.css |
363 B | 0 B | |
build/block-library/blocks/query/editor-rtl.css |
179 B | 0 B | |
build/block-library/blocks/query/editor.css |
179 B | 0 B | |
build/block-library/blocks/quote/editor-rtl.css |
121 B | 0 B | |
build/block-library/blocks/quote/editor.css |
121 B | 0 B | |
build/block-library/blocks/quote/style-rtl.css |
215 B | 0 B | |
build/block-library/blocks/quote/style.css |
214 B | 0 B | |
build/block-library/blocks/rss/editor-rtl.css |
270 B | 0 B | |
build/block-library/blocks/rss/editor.css |
270 B | 0 B | |
build/block-library/blocks/rss/style-rtl.css |
314 B | 0 B | |
build/block-library/blocks/rss/style.css |
313 B | 0 B | |
build/block-library/blocks/search/editor-rtl.css |
213 B | 0 B | |
build/block-library/blocks/search/editor.css |
213 B | 0 B | |
build/block-library/blocks/search/style-rtl.css |
384 B | 0 B | |
build/block-library/blocks/search/style.css |
386 B | 0 B | |
build/block-library/blocks/separator/editor-rtl.css |
151 B | 0 B | |
build/block-library/blocks/separator/editor.css |
151 B | 0 B | |
build/block-library/blocks/separator/style-rtl.css |
281 B | 0 B | |
build/block-library/blocks/separator/style.css |
281 B | 0 B | |
build/block-library/blocks/shortcode/editor-rtl.css |
547 B | 0 B | |
build/block-library/blocks/shortcode/editor.css |
547 B | 0 B | |
build/block-library/blocks/site-logo/editor-rtl.css |
251 B | 0 B | |
build/block-library/blocks/site-logo/editor.css |
251 B | 0 B | |
build/block-library/blocks/site-logo/style-rtl.css |
166 B | 0 B | |
build/block-library/blocks/site-logo/style.css |
166 B | 0 B | |
build/block-library/blocks/social-link/editor-rtl.css |
211 B | 0 B | |
build/block-library/blocks/social-link/editor.css |
211 B | 0 B | |
build/block-library/blocks/social-links/editor-rtl.css |
749 B | 0 B | |
build/block-library/blocks/social-links/editor.css |
749 B | 0 B | |
build/block-library/blocks/social-links/style-rtl.css |
1.37 kB | 0 B | |
build/block-library/blocks/social-links/style.css |
1.37 kB | 0 B | |
build/block-library/blocks/spacer/editor-rtl.css |
321 B | 0 B | |
build/block-library/blocks/spacer/editor.css |
321 B | 0 B | |
build/block-library/blocks/spacer/style-rtl.css |
107 B | 0 B | |
build/block-library/blocks/spacer/style.css |
107 B | 0 B | |
build/block-library/blocks/subhead/editor-rtl.css |
148 B | 0 B | |
build/block-library/blocks/subhead/editor.css |
148 B | 0 B | |
build/block-library/blocks/subhead/style-rtl.css |
134 B | 0 B | |
build/block-library/blocks/subhead/style.css |
134 B | 0 B | |
build/block-library/blocks/table/editor-rtl.css |
530 B | 0 B | |
build/block-library/blocks/table/editor.css |
530 B | 0 B | |
build/block-library/blocks/table/style-rtl.css |
433 B | 0 B | |
build/block-library/blocks/table/style.css |
433 B | 0 B | |
build/block-library/blocks/tag-cloud/editor-rtl.css |
162 B | 0 B | |
build/block-library/blocks/tag-cloud/editor.css |
162 B | 0 B | |
build/block-library/blocks/tag-cloud/style-rtl.css |
145 B | 0 B | |
build/block-library/blocks/tag-cloud/style.css |
145 B | 0 B | |
build/block-library/blocks/template-part/editor-rtl.css |
644 B | 0 B | |
build/block-library/blocks/template-part/editor.css |
645 B | 0 B | |
build/block-library/blocks/text-columns/editor-rtl.css |
146 B | 0 B | |
build/block-library/blocks/text-columns/editor.css |
146 B | 0 B | |
build/block-library/blocks/text-columns/style-rtl.css |
209 B | 0 B | |
build/block-library/blocks/text-columns/style.css |
209 B | 0 B | |
build/block-library/blocks/verse/editor-rtl.css |
153 B | 0 B | |
build/block-library/blocks/verse/editor.css |
153 B | 0 B | |
build/block-library/blocks/verse/style-rtl.css |
117 B | 0 B | |
build/block-library/blocks/verse/style.css |
117 B | 0 B | |
build/block-library/blocks/video/editor-rtl.css |
547 B | 0 B | |
build/block-library/blocks/video/editor.css |
548 B | 0 B | |
build/block-library/blocks/video/style-rtl.css |
241 B | 0 B | |
build/block-library/blocks/video/style.css |
241 B | 0 B | |
build/block-library/common-rtl.css |
940 B | 0 B | |
build/block-library/common.css |
937 B | 0 B | |
build/block-library/editor-rtl.css |
9.07 kB | 0 B | |
build/block-library/editor.css |
9.07 kB | 0 B | |
build/block-library/index.js |
150 kB | 0 B | |
build/block-library/style-rtl.css |
8.34 kB | 0 B | |
build/block-library/style.css |
8.34 kB | 0 B | |
build/block-library/theme-rtl.css |
789 B | 0 B | |
build/block-library/theme.css |
790 B | 0 B | |
build/block-serialization-default-parser/index.js |
1.88 kB | 0 B | |
build/block-serialization-spec-parser/index.js |
3.06 kB | 0 B | |
build/blocks/index.js |
48.1 kB | 0 B | |
build/components/index.js |
171 kB | 0 B | |
build/components/style-rtl.css |
15.4 kB | 0 B | |
build/components/style.css |
15.4 kB | 0 B | |
build/compose/index.js |
11 kB | 0 B | |
build/core-data/index.js |
15.4 kB | 0 B | |
build/data-controls/index.js |
827 B | 0 B | |
build/data/index.js |
8.98 kB | 0 B | |
build/date/index.js |
31.8 kB | 0 B | |
build/deprecated/index.js |
769 B | 0 B | |
build/dom-ready/index.js |
571 B | 0 B | |
build/dom/index.js |
4.95 kB | 0 B | |
build/edit-navigation/index.js |
11.1 kB | 0 B | |
build/edit-navigation/style-rtl.css |
881 B | 0 B | |
build/edit-navigation/style.css |
885 B | 0 B | |
build/edit-post/index.js |
306 kB | 0 B | |
build/edit-post/style-rtl.css |
6.47 kB | 0 B | |
build/edit-post/style.css |
6.45 kB | 0 B | |
build/edit-site/index.js |
24.5 kB | 0 B | |
build/edit-site/style-rtl.css |
3.91 kB | 0 B | |
build/edit-site/style.css |
3.91 kB | 0 B | |
build/edit-widgets/index.js |
26.3 kB | 0 B | |
build/edit-widgets/style-rtl.css |
3.1 kB | 0 B | |
build/edit-widgets/style.css |
3.1 kB | 0 B | |
build/editor/editor-styles-rtl.css |
476 B | 0 B | |
build/editor/editor-styles.css |
478 B | 0 B | |
build/editor/index.js |
43.3 kB | 0 B | |
build/editor/style-rtl.css |
3.84 kB | 0 B | |
build/editor/style.css |
3.84 kB | 0 B | |
build/element/index.js |
4.63 kB | 0 B | |
build/escape-html/index.js |
735 B | 0 B | |
build/format-library/index.js |
6.74 kB | 0 B | |
build/format-library/style-rtl.css |
547 B | 0 B | |
build/format-library/style.css |
548 B | 0 B | |
build/hooks/index.js |
2.27 kB | 0 B | |
build/html-entities/index.js |
623 B | 0 B | |
build/i18n/index.js |
3.57 kB | 0 B | |
build/is-shallow-equal/index.js |
697 B | 0 B | |
build/keyboard-shortcuts/index.js |
2.54 kB | 0 B | |
build/keycodes/index.js |
1.94 kB | 0 B | |
build/list-reusable-blocks/index.js |
3.1 kB | 0 B | |
build/list-reusable-blocks/style-rtl.css |
476 B | 0 B | |
build/list-reusable-blocks/style.css |
476 B | 0 B | |
build/media-utils/index.js |
5.32 kB | 0 B | |
build/notices/index.js |
1.85 kB | 0 B | |
build/nux/index.js |
3.42 kB | 0 B | |
build/nux/style-rtl.css |
671 B | 0 B | |
build/nux/style.css |
668 B | 0 B | |
build/plugins/index.js |
2.54 kB | 0 B | |
build/primitives/index.js |
1.43 kB | 0 B | |
build/priority-queue/index.js |
790 B | 0 B | |
build/redux-routine/index.js |
2.84 kB | 0 B | |
build/reusable-blocks/index.js |
2.92 kB | 0 B | |
build/rich-text/index.js |
13.4 kB | 0 B | |
build/server-side-render/index.js |
2.77 kB | 0 B | |
build/shortcode/index.js |
1.7 kB | 0 B | |
build/token-list/index.js |
1.27 kB | 0 B | |
build/url/index.js |
2.84 kB | 0 B | |
build/viewport/index.js |
1.86 kB | 0 B | |
build/warning/index.js |
1.14 kB | 0 B | |
build/wordcount/index.js |
1.22 kB | 0 B |
LGTM! Tests are passing both on CI and locally. Left minor non-blocker suggestions. |
// Evaluate the document settings title | ||
await page.waitForSelector( '.edit-site-document-actions__title' ); | ||
const actual = await page.$eval( | ||
'.edit-site-document-actions__title', | ||
( el ) => el.innerText | ||
); |
Comment on lines
+93
to
+98
david-szabo97
Dec 15, 2020
Member
I see this snippet is used in 2 places. Can we extract this into a function? getDocumentSettingsTitle()
or something like that. Might be useful if we keep adding more tests.
I see this snippet is used in 2 places. Can we extract this into a function? getDocumentSettingsTitle()
or something like that. Might be useful if we keep adding more tests.
// Evaluate the document settings secondary title | ||
await page.waitForSelector( | ||
'.edit-site-document-actions__secondary-item' | ||
); | ||
const actual = await page.$eval( | ||
'.edit-site-document-actions__secondary-item', | ||
( el ) => el.innerText | ||
); |
Comment on lines
+66
to
+73
david-szabo97
Dec 15, 2020
Member
Might worth extracting this into a function as well. getDocumentSettingsSecondaryTitle()
, whoah that's long 😄
Might worth extracting this into a function as well. getDocumentSettingsSecondaryTitle()
, whoah that's long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jeyip commentedDec 14, 2020
Description
E2E specs were missing for the FSE document settings feature
How has this been tested?
N/A
Screenshots
Types of changes
Spec coverage
Checklist: