Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newReaderNavigation feature flag. #15382

Merged
merged 16 commits into from Nov 24, 2020
Merged

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Nov 24, 2020

Fixes #n/a

This removes the newReaderNavigation feature flag, all associated checks, and unused code.

There is more cleanup that will be done in follow-up PRs. Namely:

  • Remove unused files.
  • Address TODO: - READERNAVs.

To test:

There should be no functional changes, so just smoke test the Reader and all the filters to ensure they behave as expected.

Note: there is an existing issue with unsaving posts from the Saved filter.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 16.3 milestone Nov 24, 2020
@ScoutHarris ScoutHarris requested a review from aerych Nov 24, 2020
@ScoutHarris ScoutHarris self-assigned this Nov 24, 2020
@peril-wordpress-mobile
Copy link

@peril-wordpress-mobile peril-wordpress-mobile bot commented Nov 24, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

@peril-wordpress-mobile peril-wordpress-mobile bot commented Nov 24, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

aerych
aerych approved these changes Nov 24, 2020
Copy link
Member

@aerych aerych left a comment

Hi @ScoutHarris!
Changes look good to me. I performed a quick smoke test of the reader and the navigation seemed to work fine.
:shipit: !

@ScoutHarris
Copy link
Contributor Author

@ScoutHarris ScoutHarris commented Nov 24, 2020

Thanks @aerych !

@ScoutHarris ScoutHarris merged commit ebcba8a into develop Nov 24, 2020
8 checks passed
@ScoutHarris ScoutHarris deleted the issues/remove_reader_nav_ff branch Nov 24, 2020
@ScoutHarris ScoutHarris mentioned this pull request Nov 30, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants