New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove newReaderNavigation
feature flag.
#15382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SavedForLaterPostsNotification.
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
aerych
approved these changes
Nov 24, 2020
Hi @ScoutHarris!
Changes look good to me. I performed a quick smoke test of the reader and the navigation seemed to work fine.
!
Thanks @aerych ! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #n/a
This removes the
newReaderNavigation
feature flag, all associated checks, and unused code.There is more cleanup that will be done in follow-up PRs. Namely:
TODO: - READERNAV
s.To test:
There should be no functional changes, so just smoke test the Reader and all the filters to ensure they behave as expected.
Note: there is an existing issue with unsaving posts from the Saved filter.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.