Skip to content

/ gutenberg-mobile

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery - Media editing #2496

Merged
merged 10 commits into from Aug 14, 2020
Merged

Gallery - Media editing #2496

merged 10 commits into from Aug 14, 2020

Conversation

@geriux
Copy link
Member

@geriux geriux commented Jul 21, 2020 •
edited

Fixes #2389

Gutenberg PR -> WordPress/gutenberg#24088
WordPress iOS PR -> wordpress-mobile/WordPress-iOS#14498
WordPress Android PR -> wordpress-mobile/WordPress-Android#12497

Continuing adding media editing support to blocks, this PR adds it to Gallery block. For a more detailed description and testing plan check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to [RELEASE-NOTES.txt](RELEASE-NOTES.txt) if necessary.
@geriux
Update Gutenberg ref
f77da6b
@geriux geriux added the Media label Jul 21, 2020
@geriux geriux added this to the 1.34 milestone Jul 21, 2020
This was referenced Jul 21, 2020
Merged
Closed
Closed
@geriux
Update Gutenberg ref
037e167
@geriux geriux force-pushed the feature/gallery-media-editing branch from 10f352d to ad8e1c6 Jul 24, 2020
@geriux geriux requested a review from mkevins Jul 24, 2020
@geriux geriux marked this pull request as ready for review Jul 24, 2020
@ceyhun
Copy link
Member

@ceyhun ceyhun commented Aug 3, 2020

👋 @geriux ! We're getting ready to cut the 1.34 release branch, so I'm bumping this to the 1.35 milestone. If this needs to make the 1.35 release though, go ahead and change the milestone back and try to get this merged as soon as possible. If you're trying to get this into the release, please also let us know in Slack. 🙇
@ceyhun ceyhun modified the milestones: 1.34, 1.35 Aug 3, 2020
geriux added 2 commits Aug 5, 2020
@geriux
Merge branch 'develop' into feature/gallery-media-editing
c02b631 
# Conflicts:
#	gutenberg
@geriux
Update Gutenberg ref
a857288
@geriux geriux force-pushed the feature/gallery-media-editing branch from ad8e1c6 to 6efaf03 Aug 5, 2020
@peril-wordpress-mobile
Copy link

@peril-wordpress-mobile peril-wordpress-mobile bot commented Aug 5, 2020 •
edited

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!
@geriux
Update Gutenberg ref
888e9a1
@geriux geriux force-pushed the feature/gallery-media-editing branch from 6efaf03 to 00a6b00 Aug 6, 2020
@geriux
Update Gutenberg ref
f3204cb
@geriux geriux force-pushed the feature/gallery-media-editing branch from 00a6b00 to 4fd1280 Aug 6, 2020
@geriux
Update Gutenberg ref
1d0bfb3
@geriux geriux force-pushed the feature/gallery-media-editing branch from 4fd1280 to 13ad7de Aug 6, 2020
@geriux
Update Gutenberg ref
e69418c
@geriux geriux force-pushed the feature/gallery-media-editing branch from 13ad7de to b5599e8 Aug 13, 2020
@geriux
Merge branch 'develop' into feature/gallery-media-editing
f615613 
# Conflicts:
#	gutenberg
@geriux geriux requested a review from lukewalczak Aug 14, 2020
@geriux
Update Gutenberg ref
Loading status checks…
85b0b6e
@geriux geriux force-pushed the feature/gallery-media-editing branch from b5599e8 to 85b0b6e Aug 14, 2020
@geriux
Copy link
Member Author

@geriux geriux commented Aug 14, 2020

Hey @lukewalczak 👋 since you already approved the Gutenberg PR, can you please approve this one as well? Thanks!
@lukewalczak
lukewalczak approved these changes Aug 14, 2020
View changes
@geriux geriux merged commit 40cee3f into develop Aug 14, 2020
7 checks passed
7 checks passed
ci/circleci: Android Native Unit Tests Your tests passed on CircleCI!
Details
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device - Canaries Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device - Canaries Your tests passed on CircleCI!
Details
ci/circleci: gutenberg-mobile/Optional UI Tests Your job is on hold on CircleCI!
Details
@geriux geriux deleted the feature/gallery-media-editing branch Aug 14, 2020
@cameronvoell cameronvoell mentioned this pull request Aug 18, 2020
Merged
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewalczak lukewalczak

@mkevins mkevins

Assignees
No one assigned
Labels
Media
Projects
None yet
Milestone
1.35
Linked issues

Successfully merging this pull request may close these issues.

Gallery block: allow editing image
3 participants
@geriux @ceyhun @lukewalczak
You can’t perform that action at this time.