Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the padding for the nav block inserter content the same for all sides #24084

Merged

Conversation

@javidalkaruzi
Copy link
Contributor

@javidalkaruzi javidalkaruzi commented Jul 21, 2020

Description

This pull request addressed #24078. The padding for the nav block inserter was updated to be the same for all sides.

How has this been tested?

Observed on Ubuntu 20.04 with the following browsers

  • Chromium Version 84.0.4147.89 (Official Build) snap (64-bit)
  • Firefox 78.0.2 (64-bit)

Screenshots

Original
image

Fixed
image

Types of changes

Bug fix

@youknowriad youknowriad requested a review from mapk Jul 21, 2020
@mapk
mapk approved these changes Jul 21, 2020
Copy link
Contributor

@mapk mapk left a comment

Yep, that's it! Thanks for taking care of this. :)

2020-07-21 08-57-37 2020-07-21 08_57_50

@youknowriad youknowriad merged commit a6ac1bf into WordPress:master Jul 22, 2020
15 checks passed
15 checks passed
Cancel Previous Runs
Details
Check Check
Details
build
Details
Admin - 1
Details
Compare performance with master
Details
pull-request-automation
Details
test (gutenberg-editor-gallery)
Details
test (gutenberg-editor-gallery)
Details
All
Details
JavaScript
Details
Admin - 2
Details
PHP
Details
Admin - 3
Details
Mobile
Details
Admin - 4
Details
@github-actions github-actions bot added this to the Gutenberg 8.7 milestone Jul 22, 2020
@javidalkaruzi javidalkaruzi deleted the javidalkaruzi:fix/nav-block-inserter-padding branch Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.