Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Clarify custom link color documentation for themes #24056
Conversation
Size Change: -1.03 MB (89%) Total Size: 1.16 MB
|
Filename | Size | Change | |
---|---|---|---|
build/a11y/index.js |
1.14 kB | 0 B | |
build/annotations/index.js |
3.67 kB | 0 B | |
build/api-fetch/index.js |
3.44 kB | 0 B | |
build/autop/index.js |
2.82 kB | 0 B | |
build/blob/index.js |
620 B | 0 B | |
build/block-directory/index.js |
7.93 kB | 0 B | |
build/block-editor/index.js |
125 kB | 0 B | |
build/block-library/index.js |
133 kB | 0 B | |
build/block-library/theme-rtl.css |
728 B | 0 B | |
build/block-library/theme.css |
729 B | 0 B | |
build/block-serialization-default-parser/index.js |
1.88 kB | 0 B | |
build/block-serialization-spec-parser/index.js |
3.1 kB | 0 B | |
build/blocks/index.js |
48.2 kB | 0 B | |
build/components/index.js |
200 kB | 0 B | |
build/compose/index.js |
9.68 kB | 0 B | |
build/core-data/index.js |
11.8 kB | 0 B | |
build/data-controls/index.js |
1.29 kB | 0 B | |
build/data/index.js |
8.45 kB | 0 B | |
build/date/index.js |
5.38 kB | 0 B | |
build/deprecated/index.js |
772 B | 0 B | |
build/dom-ready/index.js |
568 B | 0 B | |
build/dom/index.js |
3.23 kB | 0 B | |
build/edit-navigation/index.js |
10.9 kB | 0 B | |
build/edit-navigation/style-rtl.css |
1.08 kB | 0 B | |
build/edit-navigation/style.css |
1.08 kB | 0 B | |
build/edit-post/index.js |
304 kB | 0 B | |
build/edit-post/style-rtl.css |
5.61 kB | 0 B | |
build/edit-post/style.css |
5.61 kB | 0 B | |
build/edit-site/index.js |
17 kB | 0 B | |
build/edit-site/style-rtl.css |
3.06 kB | 0 B | |
build/edit-site/style.css |
3.06 kB | 0 B | |
build/edit-widgets/index.js |
9.38 kB | 0 B | |
build/edit-widgets/style-rtl.css |
2.45 kB | 0 B | |
build/edit-widgets/style.css |
2.45 kB | 0 B | |
build/editor/editor-styles-rtl.css |
537 B | 0 B | |
build/editor/editor-styles.css |
539 B | 0 B | |
build/editor/index.js |
45.3 kB | 0 B | |
build/element/index.js |
4.65 kB | 0 B | |
build/escape-html/index.js |
733 B | 0 B | |
build/format-library/index.js |
7.72 kB | 0 B | |
build/format-library/style-rtl.css |
547 B | 0 B | |
build/format-library/style.css |
548 B | 0 B | |
build/hooks/index.js |
2.13 kB | 0 B | |
build/html-entities/index.js |
621 B | 0 B | |
build/i18n/index.js |
3.56 kB | 0 B | |
build/is-shallow-equal/index.js |
711 B | 0 B | |
build/keyboard-shortcuts/index.js |
2.52 kB | 0 B | |
build/keycodes/index.js |
1.94 kB | 0 B | |
build/list-reusable-blocks/index.js |
3.11 kB | 0 B | |
build/list-reusable-blocks/style-rtl.css |
476 B | 0 B | |
build/list-reusable-blocks/style.css |
476 B | 0 B | |
build/media-utils/index.js |
5.33 kB | 0 B | |
build/notices/index.js |
1.79 kB | 0 B | |
build/nux/index.js |
3.4 kB | 0 B | |
build/nux/style-rtl.css |
671 B | 0 B | |
build/nux/style.css |
668 B | 0 B | |
build/plugins/index.js |
2.56 kB | 0 B | |
build/primitives/index.js |
1.41 kB | 0 B | |
build/priority-queue/index.js |
789 B | 0 B | |
build/redux-routine/index.js |
2.85 kB | 0 B | |
build/rich-text/index.js |
13.9 kB | 0 B | |
build/server-side-render/index.js |
2.71 kB | 0 B | |
build/shortcode/index.js |
1.7 kB | 0 B | |
build/token-list/index.js |
1.27 kB | 0 B | |
build/url/index.js |
4.06 kB | 0 B | |
build/viewport/index.js |
1.85 kB | 0 B | |
build/warning/index.js |
1.14 kB | 0 B | |
build/wordcount/index.js |
1.17 kB | 0 B |
This sounds right, thanks! |
@kjellr Hi there! I'm actually testing this feature right now and I'm finding the linked documentation a bit hard to follow. It might be a good idea to provide a
A more detailed explanation here would be helpful as well since I find this confusing. Is this a step you have to do if you do not have an |
Would this update make this clearer? If a theme opts in, it should define default link colors in {
"global": {
"styles": {
"color": {
"link": "hotpink"
}
}
}
} If the theme styles the link color in its stylesheets (editor and front-end), it should ensure it maps to the a {
color: var(--wp--style--color--link);
} |
@nosolosw That's perfect! Thank you for that! |
Excellent suggestion, thanks @metalandcoffee and @nosolosw! I've added that in f988afc and will merge in as soon as the tests pass. |
kjellr commentedJul 20, 2020
Following up on #23590, this PR clarifies how themes can properly opt-in and support the experimental custom link color.
@nosolosw, does this look about right to you?