Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is-shallow-equal: Convert to ESM #26833

Open
wants to merge 2 commits into
base: master
from
Open

is-shallow-equal: Convert to ESM #26833

wants to merge 2 commits into from
+22 −58

Conversation

@saramarcondes
Copy link
Contributor

@saramarcondes saramarcondes commented Nov 9, 2020

Description

This PR converts is-shallow-equal to ES modules. I'm proposing this in order to allow it to be consumed in an ESM context. ES modules have matured in node to the point where this should be viable.

How has this been tested?

Original tests continue to pass. Build passes.

Types of changes

Non-breaking build changes. This will not introduce any changes to how the package is consumed, just the way it is built.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@saramarcondes
is-shallow-equal: Convert to ESM
Loading status checks…
717299e
@saramarcondes saramarcondes requested a review from sirreal Nov 9, 2020
@saramarcondes saramarcondes self-assigned this Nov 9, 2020
@saramarcondes saramarcondes mentioned this pull request Nov 9, 2020
Open
@github-actions
Copy link

@github-actions github-actions bot commented Nov 9, 2020 •
edited

Size Change: -8 B (0%)

Total Size: 1.21 MB

Filename Size Change
build/block-editor/index.js 133 kB -1 B
build/components/index.js 171 kB -1 B
build/data/index.js 8.74 kB -2 B (0%)
build/dom/index.js 4.46 kB +1 B
build/edit-site/index.js 22.5 kB -1 B
build/edit-widgets/index.js 26.2 kB +3 B (0%)
build/editor/index.js 42.5 kB +1 B
build/element/index.js 4.62 kB +1 B
build/i18n/index.js 3.57 kB -1 B
build/is-shallow-equal/index.js 706 B -6 B (0%)
build/keyboard-shortcuts/index.js 2.52 kB +1 B
build/list-reusable-blocks/index.js 3.1 kB -3 B (0%)
build/notices/index.js 1.77 kB +5 B (0%)
build/nux/index.js 3.4 kB -1 B
build/shortcode/index.js 1.69 kB -2 B (0%)
build/token-list/index.js 1.27 kB +1 B
build/viewport/index.js 1.83 kB -2 B (0%)
build/warning/index.js 1.14 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.77 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/index.js 8.71 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11.2 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 8.96 kB 0 B
build/block-library/editor.css 8.96 kB 0 B
build/block-library/index.js 147 kB 0 B
build/block-library/style-rtl.css 8.05 kB 0 B
build/block-library/style.css 8.05 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/blocks/index.js 48 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/compose/index.js 9.87 kB 0 B
build/core-data/index.js 12.5 kB 0 B
build/data-controls/index.js 771 B 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 769 B 0 B
build/dom-ready/index.js 571 B 0 B
build/edit-navigation/index.js 11.1 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 305 kB 0 B
build/edit-post/style-rtl.css 6.41 kB 0 B
build/edit-post/style.css 6.39 kB 0 B
build/edit-site/style-rtl.css 3.91 kB 0 B
build/edit-site/style.css 3.91 kB 0 B
build/edit-widgets/style-rtl.css 3.13 kB 0 B
build/edit-widgets/style.css 3.13 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.86 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.16 kB 0 B
build/html-entities/index.js 623 B 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.31 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/reusable-blocks/index.js 3.05 kB 0 B
build/rich-text/index.js 13.4 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/url/index.js 4.06 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action
@saramarcondes
is-shallow-equal: Fix test import for ci
Loading status checks…
c692271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal

At least 1 approving review is required to merge this pull request.

Assignees

@saramarcondes saramarcondes

Labels
[Package] is-shallow-equal [Type] Build Tooling [Type] Enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@saramarcondes
You can’t perform that action at this time.