Size Change: -932 B (0%)

Total Size: 1.21 MB

_{compressed-size-action}

I left a comment in case you'd like to do a few more tweaks while you're in there

Love that idea!

I am going to push each one to break them apart. Then I will collect them all in the issue so there's a record of the changes. I have made a variable as there wasn't one for the font size, I think having one could be useful. I could just set it to 13px though if not. Here is the result:

@jasmussen I just made a commit to this PR that I would love feedback on, that is regarding the removal of gradients on search results. Here is a before and after:

Before:

After:

I can see what use they are for longer results, but as they interfer with the hover, I am wondering if we could remove them? Or perhaps remove them on hover? I am interested in feedback on this.

From #26551 (comment), yeah I think we should set that to 13px.

Also looking at it, removing the left indentation did not work as well as I'd hoped. I think the indentation of the page items below are probably the source of that problem, but in order to keep this PR small we should probably just add back that subheading indentation and look at the indentation overall as a separate task.

look at the indentation overall as a separate task.

Sure, that's something I'm happy to explore later on as think a few areas could benefit from analysis over whether they indent or not and having some tightening up around that.

I just added a commit that brings in some more grid variables - great to align a few more while there. It also reverts the indent.

Here is what this now looks like:

Yep, that's good. Also good to remove that new variable from the stylesheet, they are worth adding occasionally but we should be careful adding too many, as they are meant to be used widely.

@jasmussen thanks, did a clean up. I have a few more things to add to this PR before merging too. I'll work on the icon in next pass as have that file now 🙌🏻

I have added the updates icon. Props to @jameskoster for help finding the location there.

Before

After

One more additional icon change is to bring in the '+' with updated styling.

Before

After

Further clean-up

This does open up more cleanup potential where the url icon isn't aligning with the +. Here you can see that quite clearly:

Feedback

I didn't bring in the background as the adding blocks have, however this does help visually. There could be an argument for that here, so I am going to put on the feedback label again for some thoughts before moving to commit. Here is what that looks like:

Next steps

This PR is ready once these icons have feedback to move to code review and potentially commit.

When trying to compile this I'm getting a "Error: Undefined variable. ... font-size: $helptext-font-size;`

I am just trying to get tests to pass but the variable has been updated and some iterations done to icon placement. After that as this had a code review, I will look to head to commit. Thanks everyone for the help in getting here.

Looks like tests have passed so going to commit this one. Thank you everyone.