Opened 3 months ago
Last modified 7 weeks ago
#5247 accepted enhancement
Import Hosting Handbook Markdown from Github
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Handbooks | Keywords: | has-patch |
Cc: |
Description
In #5240, a hosting handbook repo was created: https://github.com/wordpress/hosting-handbook
Now, I'm looking to figure out the best way to set up automated import of the Markdown there.
I noticed that both WP-CLI and Gutenberg are set up to auto-import, with slightly different ways of using the library plugin.
I've tested importing on a VVV meta repo, but am having trouble testing the styles.
Attached is a first draft of the WP-CLI handbook plugin ported to the hosting handbook. Not sure if it's better to go this route, or duplicate less code somehow.
Attachments (1)
Change History (14)
This ticket was mentioned in Slack in #hosting-community by mike. View the logs.
3 months ago
#2
follow-up:
↓ 3
@
3 months ago
Ah, I should note, I did notice that assets/images don't seem to get added to the WP media library on import.
I'm not sure if I did something wrong there, if they should be transformed, or if the intended behavior is to link to the assets elsewhere.
#3
in reply to:
↑ 2
;
follow-up:
↓ 4
@
3 months ago
Replying to mikeschroder:
Ah, I should note, I did notice that assets/images don't seem to get added to the WP media library on import.
I don't think there's any handling for images, and I'm not sure any of the existing handbooks that use GitHub have them.
#4
in reply to:
↑ 3
@
3 months ago
Replying to dd32:
I don't think there's any handling for images, and I'm not sure any of the existing handbooks that use GitHub have them.
Thanks; I wondered if maybe that was why Gutenberg's docs seem to use Cloudup for images. The hosting handbook only has two images at the moment, so it wouldn't be hard to move them wherever they need to be, then document how to add future images.
#5
follow-up:
↓ 6
@
3 months ago
so it wouldn't be hard to move them wherever they need to be, then document how to add future images.
I would recommend just uploading them to the media library manually, and inserting the wordpress.org link into the markdown :)
If that becomes a problem long-term, someone can offer to add sideloading functionality to the handbook plugins.
#6
in reply to:
↑ 5
@
3 months ago
Replying to dd32:
I would recommend just uploading them to the media library manually, and inserting the wordpress.org link into the markdown :)
If that becomes a problem long-term, someone can offer to add sideloading functionality to the handbook plugins.
Thanks! Sounds like a plan.
These are already uploaded, and the links have been changed + docs added.
This ticket was mentioned in Slack in #hosting-community by mike. View the logs.
3 months ago
This ticket was mentioned in Slack in #meta by tacoverdo. View the logs.
3 months ago
#9
follow-up:
↓ 10
@
2 months ago
@coffee2code Is there a new importer that doesn't need to be copy-pasted every time? I think you're far more familiar than me with the handbooks..
#10
in reply to:
↑ 9
;
follow-up:
↓ 11
@
2 months ago
Replying to dd32:
@coffee2code Is there a new importer that doesn't need to be copy-pasted every time? I think you're far more familiar than me with the handbooks..
Unfortunately, no. I believe heretofore, no other site other than DevHub had use for a GitHub docs importer until now. The Gutenberg demo site did have its own version introduced a couple months after DevHub introduced a specialized one for the REST API docs. But that was decommissioned early last year as the DevHub docs importer was abstracted into a base class to accommodate multiple imported docs (REST API, Coding Standards, and Block Editor). At which point the Gutenberg site docs importer was itself decommissioned.
The base docs importer code is only minimally DevHub-branded and specific and could probably be made general-purpose and integrated into the Handbooks plugin. I'll give it a go.
#11
in reply to:
↑ 10
@
8 weeks ago
Replying to coffee2code:
Unfortunately, no. I believe heretofore, no other site other than DevHub had use for a GitHub docs importer until now.
Thanks so much for looking into this! It would be great to have something more abstracted/general.
I'm pretty sure you're aware, but just to be sure, it looks like the WP-CLI Handbook / plugin also uses a Markdown importer, and that's the one I initially based off of.
#12
follow-up:
↓ 13
@
7 weeks ago
- Owner set to coffee2code
- Status changed from new to accepted
- Type changed from defect to enhancement
@mikeschroder: Just to confirm, has all of the data in the existing handbook pages (on make/hosting) been incorporated into the GH version? I don't want to inadvertently overwrite anything that'll be missed.
#13
in reply to:
↑ 12
@
7 weeks ago
Replying to coffee2code:
@mikeschroder: Just to confirm, has all of the data in the existing handbook pages (on make/hosting) been incorporated into the GH version? I don't want to inadvertently overwrite anything that'll be missed.
Yes! It was all ported to the Github version, and it has been worked on there since.
First pass -- Hosting Handbook importer plugin.