Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass block pattern name when using insertBlocks #25165

Merged
merged 4 commits into from Sep 15, 2020
Merged

Conversation

@apeatling
Copy link
Contributor

@apeatling apeatling commented Sep 8, 2020

Description

With the INSERT_BLOCKS action, there is currently no way to tell the difference between a number of arbitrary blocks being inserted versus a defined block pattern being inserted.

Providing the pattern namespace/name within the insertBlocks action creator means that we can determine whether or not these blocks were inserted via a block pattern.

The value of patternName is the block pattern namespace and name if inserted via a pattern, and boolean false if not.

This is information that could be useful for showing the pattern in the undo history, or for plugins to take advantage of.

How has this been tested?

Tested locally, all automated tests passing.

Types of changes

New feature (non-breaking change which adds functionality)

To Test

  • Insert a block pattern
  • Confirm that the INSERT_BLOCK action has passed the pattern name in the object
  • Insert a block, and confirm that the pattern name is false

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
…k pattern namespace if blocks have been inserted from a pattern.
@github-actions
Copy link

@github-actions github-actions bot commented Sep 8, 2020

Size Change: +262 B (0%)

Total Size: 1.2 MB

Filename Size Change
build/annotations/index.js 3.67 kB +2 B (0%)
build/block-directory/index.js 8.54 kB +45 B (0%)
build/block-editor/index.js 128 kB -348 B (0%)
build/block-editor/style-rtl.css 11.1 kB +3 B (0%)
build/block-editor/style.css 11.1 kB +3 B (0%)
build/block-library/editor-rtl.css 8.68 kB +43 B (0%)
build/block-library/editor.css 8.68 kB +44 B (0%)
build/block-library/index.js 139 kB +182 B (0%)
build/blocks/index.js 47.8 kB +132 B (0%)
build/components/index.js 200 kB -65 B (0%)
build/compose/index.js 9.68 kB +1 B
build/core-data/index.js 12.3 kB +21 B (0%)
build/data-controls/index.js 1.29 kB +2 B (0%)
build/data/index.js 8.54 kB -4 B (0%)
build/date/index.js 31.9 kB -2 B (0%)
build/dom/index.js 4.47 kB -2 B (0%)
build/edit-navigation/index.js 11.7 kB -4 B (0%)
build/edit-post/index.js 305 kB +4 B (0%)
build/edit-site/index.js 19.3 kB -81 B (0%)
build/edit-widgets/index.js 12.2 kB +108 B (0%)
build/edit-widgets/style-rtl.css 2.55 kB +94 B (3%)
build/edit-widgets/style.css 2.55 kB +94 B (3%)
build/editor/index.js 45.6 kB -10 B (0%)
build/element/index.js 4.65 kB +4 B (0%)
build/format-library/index.js 7.72 kB +2 B (0%)
build/html-entities/index.js 621 B -1 B
build/i18n/index.js 3.56 kB -2 B (0%)
build/is-shallow-equal/index.js 710 B -1 B
build/keyboard-shortcuts/index.js 2.52 kB -1 B
build/keycodes/index.js 1.94 kB -2 B (0%)
build/list-reusable-blocks/index.js 3.12 kB -1 B
build/media-utils/index.js 5.32 kB +2 B (0%)
build/notices/index.js 1.79 kB +1 B
build/plugins/index.js 2.56 kB -1 B
build/redux-routine/index.js 2.85 kB -3 B (0%)
build/rich-text/index.js 13.9 kB -1 B
build/server-side-render/index.js 2.77 kB -2 B (0%)
build/url/index.js 4.06 kB +5 B (0%)
build/warning/index.js 1.14 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.41 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-library/style-rtl.css 7.59 kB 0 B
build/block-library/style.css 7.58 kB 0 B
build/block-library/theme-rtl.css 754 B 0 B
build/block-library/theme.css 754 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/edit-navigation/style-rtl.css 1.16 kB 0 B
build/edit-navigation/style.css 1.16 kB 0 B
build/edit-post/style-rtl.css 6.26 kB 0 B
build/edit-post/style.css 6.25 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/style-rtl.css 3.81 kB 0 B
build/editor/style.css 3.81 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@aaronrobertshaw
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw commented Sep 10, 2020

I've had a little trouble testing this one using Redux DevTools. The action is pretty elusive and disappears before I can select it and inspect its data. Using console.log() and debugger statements though show the pattern name as expected or false when only inserting a block.

The test suite all passed as well.

@apeatling
Copy link
Contributor Author

@apeatling apeatling commented Sep 10, 2020

Updated to use meta and also added a new test. Ready for another look. 👍

@apeatling apeatling requested a review from glendaviesnz Sep 10, 2020
@apeatling
Copy link
Contributor Author

@apeatling apeatling commented Sep 14, 2020

@youknowriad How does this look now with the meta change implemented?

Copy link
Contributor

@youknowriad youknowriad left a comment

This is looking good to me. @mtias thoughts?

@mtias
mtias approved these changes Sep 15, 2020
@apeatling apeatling merged commit 7323c09 into master Sep 15, 2020
15 checks passed
15 checks passed
Cancel Previous Runs
Details
Check Check
Details
build
Details
Admin - 1
Details
Compare performance with master
Details
pull-request-automation
Details
test (gutenberg-editor-gallery)
Details
test (gutenberg-editor-gallery)
Details
All
Details
JavaScript
Details
Admin - 2
Details
PHP
Details
Admin - 3
Details
Mobile
Details
Admin - 4
Details
@apeatling apeatling deleted the add/pattern-insertion-data branch Sep 15, 2020
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 15, 2020
@glendaviesnz glendaviesnz mentioned this pull request Sep 18, 2020
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.