Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block adding Glossary Terms containing punctuation with error/warning #768

Closed
garretthyder opened this issue Jun 30, 2017 · 4 comments
Closed

Comments

@garretthyder
Copy link

@garretthyder garretthyder commented Jun 30, 2017

Hello,

This issue stems from #762 where it was mentioned that punctuation is stripped when doing a term lookup, as such I'd suggest the Glossary block creation of those terms, and possibly add a way to mark invalid terms that already exist.

Thanks

@toolstack
Copy link
Contributor

@toolstack toolstack commented Jun 30, 2017

I don't think it's worth going back to try and detect existing 'broken' glossary terms programatically, they don't break anything per say and if someone edits one it will give the error.

@garretthyder
Copy link
Author

@garretthyder garretthyder commented Jun 30, 2017

Sounds good, you're right is probably more work than it's worth to test the existing. So just an error on submission would suffice

@ocean90
Copy link
Member

@ocean90 ocean90 commented Jul 1, 2017

I don't think we should block them, why not removing such characters automatically? Sounds also like a rare case since we request a term and not a sentence.

@toolstack
Copy link
Contributor

@toolstack toolstack commented Jul 1, 2017

Agree it's a rare case, blocking seemed safer as you might get strange cases where simply removing them would not be good (typos for example).

The block and error makes sure it gets some attention, a simple replace might create unwanted entries.

Also, doing a bit of research seemed to show \b was very implementation dependent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.