Replace "Page Break" icon with a Material version #15627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
kjellr
added
[Block] Page Break
[Type] Enhancement
kjellr
changed the title
sbardian
pushed a commit
to sbardian/gutenberg
that referenced
this issue
Jul 29, 2019
dd32
pushed a commit
to dd32/gutenberg
that referenced
this issue
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The current "Page Break" block icon appears to be based on the "Pages" Gridicon. For greater consistency as we expand into more blocks that use a "page" icon, we should source from either Material or Dashicons. To that end, this PR replaces the page break icon with one based on the "File" icon from Material.
Before:
After: