Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRestore block movers to focus mode #15109
+0
−5
Conversation
kjellr
added
Blocks
Good First Review
labels
Apr 22, 2019
kjellr
requested review from
mapk and
jorgefilipecosta
Apr 22, 2019
kjellr
requested review from
ellatrix,
gziolo,
noisysocks,
talldan and
youknowriad
as
code owners
Apr 22, 2019
kjellr
self-assigned this
Apr 22, 2019
This comment has been minimized.
This comment has been minimized.
|
hi @kjellr I ran the code and the block mover is too close to the block toolbar, tried with twentynineteen and twentyfourteen
|
kjellr
requested a review
from chrisvanpatten
as a
code owner
Apr 22, 2019
This comment has been minimized.
This comment has been minimized.
|
Good catch, @draganescu! It's weird that didn't show up for me initially. Anyway, I removed the style that was causing that in ecc932f. |
kjellr
requested a review
from jasmussen
Apr 25, 2019
This comment has been minimized.
This comment has been minimized.
|
Yep, works for me Just needs a code sanity check, I suppose! |
gziolo
approved these changes
Apr 26, 2019
draganescu
merged commit 3021cf6
into
master
Apr 26, 2019
1 check passed
Travis CI - Pull Request
Build Passed
Details
draganescu
deleted the
update/restore-block-movers-to-focus-mode
branch
Apr 26, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks, everyone! |
This was referenced Apr 29, 2019
youknowriad
added this to the 5.6 (Gutenberg) milestone
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kjellr commentedApr 22, 2019
Closes #14670.
Currently Focus mode does not include a way to rearrange blocks. This PR corrects that by re-adding block movers to that mode. Conceptually, these seem fine to re-introduce because the movers shouldn't necessarily break your focus anyway: they only appear when you hover on a specific part of a block, and they fade away when you type.
Before:
After: