Disable SCRIPT_DEBUG for local e2e tests run #14638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
aduth,
ajitbohra,
nerrad,
ntwb and
youknowriad
as code owners
gziolo
added
Automated Testing
aduth
reviewed
Mar 26, 2019
| @@ -65,6 +65,7 @@ fi | |||
| # Make sure the uploads and upgrade folders exist and we have permissions to add files. | |||
| echo -e $(status_message "Ensuring that files can be uploaded...") | |||
| docker-compose $DOCKER_COMPOSE_FILE_OPTIONS run --rm $CONTAINER chmod 767 /var/www/html/wp-content/plugins | |||
| docker-compose $DOCKER_COMPOSE_FILE_OPTIONS run --rm $CONTAINER chmod 767 /var/www/html/wp-config.php | |||
There was a problem hiding this comment.
Multiple file paths can be passed to a single chmod command. Could (marginally) improve performance to avoid multiple separate docekr-compose run.
There was a problem hiding this comment.
I'm wondering if we still need it to be honest. I suspect that we were using the wrong user for WP-CLI dedicated to e2e tests. However, I wanted to unblock other folks and I didn't investigate further.
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
There is this issue that e2e tests run locally will fail at the moment because
SCRIPT_DEBUGis set totrueand we need to fix React warnings. It is disabled on Travis and this PR does it for local env as well.In theorhy we should need only:
However, I run into some issues where I could update
SCRIPT_DEBUGforwordpresscontainer but notwordpress_e2e_testscontainer so I applied a few changes based on this Stack Overflow page:https://stackoverflow.com/questions/50999848/how-to-run-wp-cli-in-docker-compose-yml/51001043#51001043
I also removed
bin/run-e2e-tests.shfile which is no longer in use.How has this been tested?
npm run test-e2elocally.