WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#33077 closed defect (bug) (fixed)

pw-weak vs. pw_weak, IDs vs. classes

Reported by: johnjamesjacoby Owned by: markjaquith
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: has-patch
Focuses: ui, administration Cc:

Description

Breaking apart from #WP32589, there are a few places where the pw-weak clean-up in r33246 missed a few spots.

Related to this is the for label attribute, which isn't necessary when the label wraps the checkbox, and actually causes targeting issues (in Webkit for sure; possibly others.)

Patch imminent.

Attachments (2)

33037.01.patch​ (1.1 KB) - added by johnjamesjacoby 2 months ago.
33077.02.patch​ (1.2 KB) - added by johnjamesjacoby 2 months ago.

Download all attachments as: .zip

Change History (8)

@johnjamesjacoby — 2 months ago

comment:1 @slackbot — 2 months ago

This ticket was mentioned in ​Slack in #core-passwords by jjj. ​View the logs.

@johnjamesjacoby — 2 months ago

comment:2 @johnjamesjacoby — 2 months ago

33077.02.patch is a portion of 32589.10.patch, surgically removed for easier scrutinizing.

comment:3 @markjaquith — 2 months ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 33363:

Fix up and normalize pw_weak/pw-weak IDs and labels.

props johnjamesjacoby
fixes #33077

comment:4 @johnjamesjacoby — 2 months ago

Helen suggested in Slack to remove the pw-weak ID's on the checkboxes entirely.

I can confirm they are no longer referenced in our CSS or JS, so it's safe to remove them if we'd like.

comment:6 @SergeyBiryukov — 2 months ago

In 33419:

Remove unused pw-weak ID attributes.

see #33077.

Note: See TracTickets for help on using tickets.