Media List (wp-list-table): attachment thumbnails overlap each other

[tyxla]

When viewing the Media Library in list view, the thumbnails overlap the next entry.

Attaching a preview of the issue.

Attaching a preview of the issue

Since the thumbnail container is absolute, I suggest that we fix this by adding a min height of the .media-info. This will work fine for both cases - image thumbnails (which are 60px in height), and icon thumbnails (which are 64px in height).

Patch coming in a minute.

Adding min height to .media-info to resolve the issue with overlapping thumbnails in media list view.

Here is a preview of the fixed issue.

Possibly a result from recent Admin UI work.

/cc @helen @stephdau

Similar/related to https://core.trac.wordpress.org/ticket/32395#comment:10

Looks like row actions are missing :) Going to dig into that first, though we should probably do this anyway just in case.

In 32798:

Media list table: Restore row actions.

see #29881, #32657.

Adding the min-height would make each row taller for not much reason given the default state, though I do wonder if we should protect against this. Thoughts?

Updating @helen's version to fix a couple of minor issues and update the CSS.

Oh well. How could I have missed that the row actions are missing. :) Thanks for noticing that.

But with the latest commit [32798] I have some PHP notices appearing there. Turns out that they are because of bad parameter naming for handle_row_actions(). I've attached a patch that addresses these, and updated the method docs as well.

Also, I've updated the CSS for consistency with that solution. With this approach, min-height will not be necessary anymore.

This ticket was mentioned in ​Slack in #core by tyxla. ​View the logs.

In 32805:

Media list table: Avoid PHP notices by using the proper variables.

Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.