WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 2 months ago

Last modified 2 months ago

#31460 closed defect (bug) (fixed)

Twenty Fifteen: Sidebar Background Color when a header image is in use

Reported by: poldira Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.1.1
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: Cc:

Description

With a Header Background Image in use, Customizer will set the background color of the Header and Sidebar in preview. After save however, color doesn't render. Currently using a transparent png for the Header Background. Navigating away from the homepage also drops the color.

Current theme: Twenty Fifteen

Attachments (1)

31460.diff​ (1.1 KB) - added by valendesigns 2 months ago.

Download all attachments as: .zip

Change History (7)

comment:1 @slackbot — 4 months ago

This ticket was mentioned in ​Slack in #core-customize by celloexpressions. ​View the logs.

comment:2 @celloexpressions — 4 months ago

  • Component changed from Customize to Bundled Theme
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Owner set to valendesigns
  • Status changed from new to assigned
  • Summary changed from Customizer Header and Sidebar Background Color to Twenty Fifteen: Sidebar Background Color when a header image is in use

Looks like the issue here is that Twenty Fifteen doesn't display the sidebar/header background color when a header image is in use. But it is shown in the Customizer preview because it's rendered there via JS. We should probably add support for that color showing up when an image is also in use so that it works with transparent PNGs. @valendesigns will investigate later today.

@valendesigns — 2 months ago

comment:3 @valendesigns — 2 months ago

  • Keywords has-patch needs-testing added; needs-patch removed
  • Milestone changed from Future Release to 4.3

The background image CSS used background instead of background-image and wrote over the background-color attribute because of it. Patch 31460.diff​ should solve the issue as I understand it. Sorry for the delay.

comment:4 @obenland — 2 months ago

  • Owner changed from valendesigns to obenland
  • Status changed from assigned to accepted

comment:5 @obenland — 2 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 33092:

Twenty Fifteen: Display sidebar background color with Header Image.

If the header image has a transparent background, the sidebar background color
should be visible. With the background shorthand it could never be over set
on the front-end however.

Props valendesigns.
Fixes #31460.

comment:6 @poldira — 2 months ago

Thanks for rocking this all!

Note: See TracTickets for help on using tickets.