#30902 closed task (blessed) (fixed)
Create new dashicons (4.3)
Reported by: | EmpireOfLight | Owned by: | melchoyce |
---|---|---|---|
Milestone: | 4.3 | Priority: | normal |
Severity: | normal | Version: | 4.1 |
Component: | Administration | Keywords: | has-patch needs-refresh |
Focuses: | ui, administration | Cc: |
Description (last modified by SergeyBiryukov)
This is a follow-up to #29444, which ended with @liljimmi listing an inventory of old and new unfulfilled requests for the next ticket:
- "Sticky" icon for posts
- "Move" icon
- Email (using the @ sign)
- Automattic products mini-logos
- LinkedIn and other missing social network icons
- Exclamation mark icon
- Icons for different currencies. Such as $, €, £ etc.
- A loading icon to replace the current gif loading icon (still in debate)
- A table icon for TinyMCE and a dashicon variant for each icon in the TinyMCE icon font.
- A filter icon
- An animal icon (for zoo websites, pet shops, etc.)
- Icon for WordPress Multisite
- Icons to represent CSS ( e.g. {} ) and shortcodes e.g. [] )
- PDF icon
- A page icon that wasn't filled/solid like the Dashicons '\f498' is (something like Noticons '\f443').
- A paperclip
- A light bulb with rays to indicate it's on (this would complement Dashicons '\f339')
Can we divvy these up? I've already made sticky posts. Anyone care to jump in on the others?
Also, what's the flow going to be for submitting new dashicons? We've discussed moving toward SVG sprite, for 4.2. This will hopefully make it easier to submit and discuss new icons.
Attachments (24)
Change History (92)
@EmpireOfLight — 8 months ago
comment:1 @SergeyBiryukov — 8 months ago
- Description modified (diff)
- Focuses ui administration added
comment:2 @melchoyce — 8 months ago
I had a couple other icons in the last thread which didn't make it into 4.1 (image filter, warning, table, filter, and sticky post). They could use another set of eyes for consistency and style. I'll reattach them here.
For now, let's hold off on making more new icons until we've had a chance to meet and discuss the plans outlined here: https://make.wordpress.org/design/2015/01/04/the-future-of-dashicons/
@melchoyce — 8 months ago
comment:4 @joelworsham — 8 months ago
#31079 was marked as a duplicate.
comment:5 @joelworsham — 8 months ago
- Version set to 4.1
There's a dashicon named "visibility", that is an eye. It would be great if there was a dashicon that was something like an eye with a line through it, or a closed eye, or something to imply "hidden" or "not visible".
comment:6 @SergeyBiryukov — 8 months ago
#31125 was marked as a duplicate.
comment:7 @mcselasvegas — 8 months ago
I would like to see a thumbs up and thumbs down icon added to the list
comment:8 @slackbot — 7 months ago
This ticket was mentioned in Slack in #design-dashicons by melchoyce. View the logs.
comment:9 @melchoyce — 7 months ago
- Summary changed from Dashicons development to Create new dashicons (4.2)
comment:10 @dd32 — 7 months ago
#31207 was marked as a duplicate.
comment:11 @Nicotine — 7 months ago
Please add the social network icon vk.com.
http://iconbird.com/view/30005_iconki_vkontakte_vkontakte
comment:12 @philip.coombes — 6 months ago
Please could you add the aircraft icon as it would work perfectly for the aircraft for sale custom post type I am working on.
@cadproadmin — 5 months ago
comment:13 @cadproadmin — 5 months ago
comment:14 @brightsidew3 — 5 months ago
comment:15 @melchoyce — 4 months ago
- Summary changed from Create new dashicons (4.2) to Create new dashicons (4.3)
Suggestion from #32200: TripAdvisor icon
Suggestion from #32169: A travel or aviation-related icon, like an airplane
Suggestion from #31079: Crossed out eye, opposite of visible
Suggestion from #31059:
- A lock that is open
- A crossed out eye (http://goo.gl/vXdoXO)
- Youtube icon
- Database icon
- pdf media icon
"random" play button(https://developer.wordpress.org/resource/dashicons/#randomize)Loading icon(https://core.trac.wordpress.org/browser/trunk/src/wp-admin/images/spinner.gif)
Suggestion from #31125: Thumbs up, thumbs down
Suggestion from https://wordpress.slack.com/archives/design/p1431196199000010: Warning
Once we restart Dashicons meetings next week, we can make a better plan for tackling new icons this cycle. In the meantime, I'm switching this ticket to be for 4.3, since we never got around to it for 4.2.
comment:16 @melchoyce — 4 months ago
#32200 was marked as a duplicate.
comment:17 @melchoyce — 4 months ago
#32169 was marked as a duplicate.
comment:18 @slackbot — 4 months ago
This ticket was mentioned in Slack in #design by melchoyce. View the logs.
@melchoyce — 4 months ago
@melchoyce — 4 months ago
comment:19 @melchoyce — 4 months ago
Added "Hidden" icon: dashicons-hidden.ai.
Preview added in dashicons-hidden-preview.png.
comment:20 @SergeyBiryukov — 4 months ago
- Milestone changed from Awaiting Review to 4.3
@melchoyce — 4 months ago
@melchoyce — 4 months ago
comment:21 @melchoyce — 4 months ago
dashicons-thumbs.ai contains thumbs up and thumbs down. The icons are adapted from Open Iconic (https://useiconic.com/open/), licensed under the MIT License. I've tweaked the icon sizing and adjusted the points to adapt to Dashicon's 20px grid. Preview in dashicons-thumbs-preview.jpg
comment:22 @slackbot — 4 months ago
This ticket was mentioned in Slack in #core-passwords by binarykitten. View the logs.
comment:23 @mkormendy — 4 months ago
comment:24 @melchoyce — 3 months ago
#32614 was marked as a duplicate.
comment:26 @dd32 — 3 months ago
#32568 was marked as a duplicate.
comment:27 @obenland — 3 months ago
- Owner set to melchoyce
- Status changed from new to assigned
comment:28 @obenland — 3 months ago
@melchoyce, is there anything you anticipate would be ready for 4.3?
comment:29 follow-up: ↓ 30 @melchoyce — 3 months ago
There's a couple in here that could likely make it in for this cycle. I'll check in with @empireoflight.
comment:30 in reply to: ↑ 29 @liljimmi — 3 months ago
Are there any that need making?
comment:31 follow-up: ↓ 32 @melchoyce — 3 months ago
Last night we started working on a Customizer icon for #32678 (https://wordpress.slack.com/archives/design/p1434596260000082). That could use some more eyes, and ideas.
An open lock based on the lock Dashicon could also be good to get in this cycle, since we have the base to work from.
At the end of the cycle, let's audit the list of icons and prune out the ones we don't think are appropriate.
comment:32 in reply to: ↑ 31 @liljimmi — 3 months ago
Sounds good, we can figure which ones to prune at one of our Slack meetings.
I can work on the lock :-)
comment:33 @EmpireOfLight — 3 months ago
Sorry I haven't been much help on these; let me know what the final vector files are ready and I'll update the font.
comment:34 @paulwilde — 3 months ago
I think a dashicons-plus-alt needs to exist which has the same thickness as dashicons-no-alt.
comment:35 @melchoyce — 3 months ago
#32748 was marked as a duplicate.
comment:36 @obenland — 3 months ago
@melchoyce, any news? If there is no need for new icons in 4.3, we can just reassign to 4.4.
comment:37 follow-up: ↓ 38 @melchoyce — 3 months ago
Sorry, I've been sick the past couple days. We can discuss this in Dashicons chat later today.
comment:38 in reply to: ↑ 37 @liljimmi — 3 months ago
I'll make the lock one now.
comment:39 @slackbot — 3 months ago
This ticket was mentioned in Slack in #design-dashicons by melchoyce. View the logs.
comment:40 @melchoyce — 3 months ago
Based on our chat today (https://wordpress.slack.com/archives/design-dashicons/p1435257113000004), we've decided to add these icons for 4.3:
- https://core.trac.wordpress.org/attachment/ticket/30902/dashicons-new_11-10-14.ai
- https://core.trac.wordpress.org/attachment/ticket/30902/dashicons-rotate.ai
- https://core.trac.wordpress.org/attachment/ticket/30902/dashicons-hidden.ai
- https://core.trac.wordpress.org/attachment/ticket/30902/dashicons-thumbs.ai
- https://core.trac.wordpress.org/attachment/ticket/30902/dashicons-unlocked.ai
- The icon from #32678
- The updated + icon @empireoflight mentioned previously, can't remember which ticket
@empireoflight, could you add these icons to the font before 4.3 beta 1, and maybe take a look at smoothing a couple of them out before they go in? In particular, I'm unsure about the ones I made in dashicons-new_11-10-14.ai and dashicons-thumbs.ai
comment:41 follow-up: ↓ 43 @EmpireOfLight — 3 months ago
https://github.com/melchoyce/dashicons is updated. There are 2 image filter icons. @melchoyce design was losing clarity at actual size, so I did one with three separate circles. I only previewed them in photoshop so the best way to compare them would be actually loading them into the admin. Where will this appear so we can see it in context?
comment:42 @melchoyce — 3 months ago
The bottom one feels more clear in this context to me. Let's nix the top.
comment:43 in reply to: ↑ 41 ; follow-up: ↓ 44 @liljimmi — 2 months ago
What are the Unicodes for all the new icons?
@EmpireOfLight — 2 months ago
Latest version of Dashicons. Please review and make sure we don't need to add/delete any.
comment:44 in reply to: ↑ 43 ; follow-up: ↓ 45 @EmpireOfLight — 2 months ago
comment:45 in reply to: ↑ 44 @liljimmi — 2 months ago
Thank you :-)
comment:46 follow-up: ↓ 47 @EmpireOfLight — 2 months ago
Also, can the thumbs-up be flipped w/CSS for thumbs-down, or do we also need a thumbs-down icon?
comment:47 in reply to: ↑ 46 ; follow-up: ↓ 48 @liljimmi — 2 months ago
CSS transform wont work in IE < 9. Is that a concern?
comment:48 in reply to: ↑ 47 @melchoyce — 2 months ago
Replying to liljimmi:
CSS transform wont work in IE < 9. Is that a concern?
It feels like enough of a concern, IMO.
comment:49 @slackbot — 2 months ago
This ticket was mentioned in Slack in #core by obenland. View the logs.
comment:50 @obenland — 2 months ago
- Keywords needs-patch added
- Type changed from enhancement to task (blessed)
This needs to be in before the weekend, preferably before beta1.
comment:51 follow-up: ↓ 55 @melchoyce — 2 months ago
Seeing a typo in the patch:
.dashicons-layout:before { content: "\ff538"; }
The second "f" should be removed.
Do you know if .dashicons-exerpt-view:before, /* Misspelled. Use .dashicons-excerpt-view instead. */ was intentionally removed? We should ideally deprecate that eventually, but I figured we'd do that kind of cleanup when we move over to SVG.
.dashicons-admin-filter should probably just be .dashicons-filter since it's not specifically going into the admin menu.
Likewise, .dashicons-lock-unlock should probably just be .dashicons-unlock.
Sorry, should have caught these earlier. Do you want me to edit your patch, or do you have time to revisit it today? I don't want to take up too much of your time.
comment:52 follow-up: ↓ 54 @obenland — 2 months ago
Anyone other than @liljimmi who should get props on the commit?
comment:53 @obenland — 2 months ago
- Keywords has-patch needs-refresh added; needs-patch removed
comment:54 in reply to: ↑ 52 @melchoyce — 2 months ago
Replying to obenland:
Anyone other than @liljimmi who should get props on the commit?
Should be @liljimmi, @empireoflight, and I for this release.
comment:55 in reply to: ↑ 51 ; follow-up: ↓ 56 @liljimmi — 2 months ago
I'll make a new patch now.
Do you know if .dashicons-exerpt-view:before, /* Misspelled. Use .dashicons-excerpt-view instead. */ was intentionally removed?
I think that may have been in trunk, but not in Git?
I'll add that back.
comment:56 in reply to: ↑ 55 @melchoyce — 2 months ago
Replying to liljimmi:
I'll make a new patch now.
Thanks!
Do you know if .dashicons-exerpt-view:before, /* Misspelled. Use .dashicons-excerpt-view instead. */ was intentionally removed?
I think that may have been in trunk, but not in Git?
I'll add that back.
Yeah, nothing really ever moves back to the Github repo from trunk. We should probably just shut it down now that we're using https://developer.wordpress.org/resource/dashicons/ for the demo.
@liljimmi — 2 months ago
Removed typo from .dashicons-layout. Changed .dashicons-admin-filter to .dashicons-filter and .dashicons-lock-unlock to .dashicons-unlock
comment:57 @melchoyce — 2 months ago
30902-3.patch looks good to go! Thanks for pushing that through today, @liljimmi. :)
comment:58 @melchoyce — 2 months ago
#32874 was marked as a duplicate.
comment:59 @slackbot — 2 months ago
This ticket was mentioned in Slack in #core by obenland. View the logs.
comment:60 @slackbot — 2 months ago
This ticket was mentioned in Slack in #design-dashicons by liljimmi. View the logs.
@liljimmi — 2 months ago
Fixed thumbs-down class and added hypnens to hyphens to thumbs-up/down icon classes
@liljimmi — 2 months ago
Changed thumbs down unicode to remove decimals, which breaks the css that displays the icon
comment:61 @ocean90 — 2 months ago
- Resolution set to fixed
- Status changed from assigned to closed
In 33108:
comment:62 @ocean90 — 2 months ago
In 33126:
comment:63 @slackbot — 2 months ago
This ticket was mentioned in Slack in #design-dashicons by melchoyce. View the logs.
comment:64 @ocean90 — 2 months ago
In 33150:
comment:65 @melchoyce — 6 weeks ago
#33075 was marked as a duplicate.
comment:66 @melchoyce — 6 weeks ago
Suggestion from #33075: move/drag icon.
comment:67 @levelfourstorefront — 5 weeks ago
love the dashicons, still no 'printer' icon...
comment:68 @slackbot — 3 weeks ago
This ticket was mentioned in Slack in #design-dashicons by melchoyce. View the logs.
Design for sticky post icon