WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 2 weeks ago

#29994 closed defect (bug) (fixed)

Border bug on empty list tables on small screens

Reported by: pento Owned by:
Milestone: 4.3 Priority: normal
Severity: minor Version:
Component: Administration Keywords: make-flow has-patch
Focuses: ui, administration Cc:

Description

When you have an empty list table, the small screen view has a border bug on the "No items found" cell.

This is caused by columns being hidden in the small screen view, but the colspan for this cell isn't updated appropriately.

Attachments (3)

IMG_2914.png (59.7 KB) - added by pento 11 months ago.
29994.diff (6.1 KB) - added by kevdotbadger 8 months ago.
IMG_4350.PNG (150.8 KB) - added by ryan 2 weeks ago.
Fixed

Download all attachments as: .zip

Change History (10)

@pento11 months ago

comment:1 @soficgr11 months ago

the problem exists because is hide one <th> description th is display:none;

comment:2 @soficgr11 months ago

  • Severity changed from normal to minor

@kevdotbadger8 months ago

comment:3 @kevdotbadger8 months ago

Looking at this, does colspanchange (defined in wp-admin/common.js) actually do anything? It's not really used anywhere and removing the code doesn't seem to effect anything? My patch works, but it's very tag only. Perhaps a refactor of colspanchange is needed?

comment:4 @bradt7 months ago

  • Keywords has-patch added

comment:5 @ryan6 months ago

On an iPhone 6+, this helped with the Tags screen but not with the comments screen. They could be separate issues, however. The comments screen is getting some related work in #29991.

comment:6 @slackbot6 months ago

This ticket was mentioned in Slack in #core-flow by boren. View the logs.

@ryan2 weeks ago

Fixed

comment:7 @ryan2 weeks ago

  • Milestone changed from Awaiting Review to 4.3
  • Resolution set to fixed
  • Status changed from new to closed

Fixed by the work on #32395.

Note: See TracTickets for help on using tickets.